From: Greg KH <greg@kroah.com>
To: David Brownell <david-b@pacbell.net>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, g.liakhovetski@pengutronix.de
Subject: Re: [patch 2.6.26-rc5] gpio: sysfs interface (updated)
Date: Tue, 22 Jul 2008 17:11:33 -0700 [thread overview]
Message-ID: <20080723001133.GA8592@kroah.com> (raw)
In-Reply-To: <200807221701.36462.david-b@pacbell.net>
On Tue, Jul 22, 2008 at 05:01:36PM -0700, David Brownell wrote:
> On Tuesday 22 July 2008, Greg KH wrote:
> >
> > > device_create_drvdata() has magically vanished from today's linux-next,
> > > so this code doesn't compile any more.
> > >
> > > This:
> > >
> > > @@ -453,8 +453,8 @@ int gpio_export(unsigned gpio, bool dire
> > > if (status == 0) {
> > > struct device *dev;
> > >
> > > - dev = device_create_drvdata(&gpio_class, desc->chip->dev, 0,
> > > - desc, "gpio%d", gpio);
> > > + dev = device_create(&gpio_class, desc->chip->dev, 0, desc,
> > > + "gpio%d", gpio);
> >
> > Should be NULL instead of 0 there, otherwise sparse will complain.
>
> The zero is a dev_t ... ?? (As Andrew just noted too.)
>
> "desc" might need to be NULL, but it's a valid pointer
> (for driver_data). I think this was a mental off-by-one...
Yes, you are correct, my mistake.
greg k-h
prev parent reply other threads:[~2008-07-23 0:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-12 18:53 [patch 2.6.26-rc5] gpio: sysfs interface (updated) David Brownell
2008-07-22 23:27 ` Andrew Morton
2008-07-22 23:28 ` Greg KH
2008-07-22 23:39 ` Andrew Morton
2008-07-22 23:51 ` Greg KH
2008-07-22 23:50 ` Andrew Morton
2008-07-23 0:02 ` Greg KH
2008-07-23 0:01 ` David Brownell
2008-07-23 0:11 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080723001133.GA8592@kroah.com \
--to=greg@kroah.com \
--cc=akpm@linux-foundation.org \
--cc=david-b@pacbell.net \
--cc=g.liakhovetski@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox