public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Daniel Walker <dwalker@mvista.com>, Ingo Molnar <mingo@elte.hu>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [git pull] scheduler updates for v2.6.27, phase #2
Date: Thu, 24 Jul 2008 04:09:54 -0700	[thread overview]
Message-ID: <20080724040954.6402e73f.akpm@linux-foundation.org> (raw)
In-Reply-To: <1216896193.7257.267.camel@twins>

On Thu, 24 Jul 2008 12:43:13 +0200 Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:

> On Mon, 2008-07-21 at 13:16 -0700, Daniel Walker wrote:
> > On Mon, 2008-07-21 at 21:23 +0200, Peter Zijlstra wrote:
> > 
> > > Does this work for you?
> > > 
> > 
> > Yours removed the warning .. I made an alternate one below only compile
> > tested, your choice..
> 
> How about this one - it seems there is a whole scala of new division
> instructions these days... :-)
> 

ain't life grand.

> 
> 
> diff --git a/kernel/sched_rt.c b/kernel/sched_rt.c
> index 47ceac9..3c38686 100644
> --- a/kernel/sched_rt.c
> +++ b/kernel/sched_rt.c
> @@ -253,7 +253,7 @@ static int do_balance_runtime(struct rt_rq *rt_rq)
>  
>  		diff = iter->rt_runtime - iter->rt_time;
>  		if (diff > 0) {
> -			do_div(diff, weight);
> +			diff = div_u64((u64)diff, weight);

Can't use div_s64() here?

>  			if (rt_rq->rt_runtime + diff > rt_period)
>  				diff = rt_period - rt_rq->rt_runtime;
>  			iter->rt_runtime -= diff;
> 

  reply	other threads:[~2008-07-24 11:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-21 15:38 [git pull] scheduler updates for v2.6.27, phase #2 Ingo Molnar
2008-07-21 16:31 ` Daniel Walker
2008-07-21 19:23   ` Peter Zijlstra
2008-07-21 20:16     ` Daniel Walker
2008-07-24 10:43       ` Peter Zijlstra
2008-07-24 11:09         ` Andrew Morton [this message]
2008-07-24 11:15           ` Peter Zijlstra
2008-07-24 11:24         ` Ingo Molnar
2008-07-24 19:12           ` Daniel Walker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080724040954.6402e73f.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=dwalker@mvista.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox