From: Matthew Wilcox <matthew@wil.cx>
To: Andi Kleen <andi@firstfloor.org>, Greg KH <greg@kroah.com>,
linux-kernel@vger.kernel.org
Subject: Oops in sched_mc_power_savings_store
Date: Thu, 24 Jul 2008 05:51:22 -0600 [thread overview]
Message-ID: <20080724115121.GA28269@parisc-linux.org> (raw)
I have no idea how you guys intended this to work, but here's the
debugging work I've done so far.
[ 89.210171] Call Trace:
[ 89.210182] [<c011c0b3>] ? sched_mc_power_savings_store+0x0/0x4a
[ 89.210198] [<c02908c0>] ? sysdev_class_store+0x38/0x40
[ 89.210213] [<c01a0b51>] ? sysfs_write_file+0xb9/0xe4
sched_mc_power_savings_store isn't a class attribute, it's a plain
attribute. So the prototypes are different. This is why we try to load
from address 2 -- it's actually the length parameter.
I don't know how our typing system let this one through. I don't know if
you want to fix this by adding an extra argument to the class_attribute
show and store methods. I don't know if sched_mc_power_savings_store
was intended to be a class attribute or not.
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next reply other threads:[~2008-07-24 11:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-24 11:51 Matthew Wilcox [this message]
2008-07-24 20:07 ` Oops in sched_mc_power_savings_store Andi Kleen
2008-07-25 15:40 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080724115121.GA28269@parisc-linux.org \
--to=matthew@wil.cx \
--cc=andi@firstfloor.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox