Re: [PATCH 11/24] x86/oprofile: Add IBS support for AMD CPUs, model specific code

[Robert Richter <robert.richter@amd.com>]

On 24.07.08 09:15:24, Maynard Johnson wrote:
> Robert Richter wrote:
>> From: Barry Kasindorf <barry.kasindorf@amd.com>
>> This patchset supports the new profiling hardware available in the
>> latest AMD CPUs in the oProfile driver.
>> Signed-off-by: Barry Kasindorf <barry.kasindorf@amd.com>
>> Signed-off-by: Robert Richter <robert.richter@amd.com>
>> ---
>>  arch/x86/oprofile/op_model_athlon.c |  257 
>> +++++++++++++++++++++++++++++++++++
>>  1 files changed, 257 insertions(+), 0 deletions(-)
>> diff --git a/arch/x86/oprofile/op_model_athlon.c 
>> b/arch/x86/oprofile/op_model_athlon.c
>> index 40ecb02..229e0b4 100644
>> --- a/arch/x86/oprofile/op_model_athlon.c
>> +++ b/arch/x86/oprofile/op_model_athlon.c
>> @@ -9,9 +9,13 @@
>>   * @author Philippe Elie
>>   * @author Graydon Hoare
>>   * @author Robert Richter <robert.richter@amd.com>
>> + * @author Barry Kasindorf
>>  */
> [snip]
>> +
>> +struct op_ibs_config {
>> +	unsigned long op_enabled;
>> +	unsigned long fetch_enabled;
>> +	unsigned long max_cnt_fetch;
>> +	unsigned long max_cnt_op;
>> +	unsigned long rand_en;
>> +	unsigned long dispatched_ops;
> I don't see dispatched_ops being used either by your kernel driver changes 
> or by the userspace changes submitted by Jason.

This is a RevC feature. I think there is a revision check needed and
thus Barry did not yet implement it.

-Robert

-- 
Advanced Micro Devices, Inc.
Operating System Research Center
email: robert.richter@amd.com