From: Randy Dunlap <randy.dunlap@oracle.com>
To: lkml <linux-kernel@vger.kernel.org>
Cc: peterz@infradead.org, mingo <mingo@redhat.com>,
akpm <akpm@linux-foundation.org>, gregkh <greg@kroah.com>
Subject: [PATCH] locking: fix mutex @key parameter kernel-doc notation
Date: Thu, 24 Jul 2008 16:58:42 -0700 [thread overview]
Message-ID: <20080724165842.fbae8993.randy.dunlap@oracle.com> (raw)
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix @key parameter to mutex_init() and one of its callers.
Warning(linux-2.6.26-git11//drivers/base/class.c:210): No description found for parameter 'key'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
drivers/base/class.c | 1 +
kernel/mutex.c | 1 +
2 files changed, 2 insertions(+)
--- linux-2.6.26-git11.orig/drivers/base/class.c
+++ linux-2.6.26-git11/drivers/base/class.c
@@ -198,6 +198,7 @@ static void class_create_release(struct
* class_create - create a struct class structure
* @owner: pointer to the module that is to "own" this struct class
* @name: pointer to a string for the name of this class.
+ * @key: the lock_class_key for this class; used by mutex lock debugging
*
* This is used to create a struct class pointer that can then be used
* in calls to device_create().
--- linux-2.6.26-git11.orig/kernel/mutex.c
+++ linux-2.6.26-git11/kernel/mutex.c
@@ -34,6 +34,7 @@
/***
* mutex_init - initialize the mutex
* @lock: the mutex to be initialized
+ * @key: the lock_class_key for the class; used by mutex lock debugging
*
* Initialize the mutex to unlocked state.
*
next reply other threads:[~2008-07-25 0:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-24 23:58 Randy Dunlap [this message]
2008-07-28 14:52 ` [PATCH] locking: fix mutex @key parameter kernel-doc notation Ingo Molnar
2008-07-28 15:39 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080724165842.fbae8993.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox