From: David Brownell <david-b@pacbell.net>
To: "Uwe Kleine-König" <Uwe.Kleine-Koenig@digi.com>,
lkml <linux-kernel@vger.kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>, Andrew Morton <akpm@linux-foundation.org>
Subject: [patch 2.6.26-git] genirq: better warning on irqchip->set_type() failure
Date: Thu, 24 Jul 2008 17:50:25 -0700 [thread overview]
Message-ID: <200807241750.25507.david-b@pacbell.net> (raw)
From: David Brownell <dbrownell@users.sourceforge.net>
While I'm glad to finally see the hole fixed whereby passing an
invalid IRQ trigger type to request_irq() would be ignored, the
current diagnostic isn't quite useful. Fixed by also listing
the trigger type which was rejected.
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -326,8 +326,8 @@ static int __irq_set_trigger(struct irq_chip *chip, unsigned int irq,
ret = chip->set_type(irq, flags & IRQF_TRIGGER_MASK);
if (ret)
- pr_err("setting flow type for irq %u failed (%pF)\n",
- irq, chip->set_type);
+ pr_err("setting trigger type %d for irq %u failed (%pF)\n",
+ flags & IRQF_TRIGGER_MASK, irq, chip->set_type);
return ret;
}
next reply other threads:[~2008-07-25 0:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-25 0:50 David Brownell [this message]
2008-07-25 7:53 ` [patch 2.6.26-git] genirq: better warning on irqchip->set_type() failure Uwe Kleine-König
2008-07-25 19:02 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807241750.25507.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=Uwe.Kleine-Koenig@digi.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox