From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Sebastien Dugue <sebastien.dugue@bull.net>
Cc: Linux-rt <linux-rt-users@vger.kernel.org>,
linux-ppc <linuxppc-dev@ozlabs.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <michael@ellerman.id.au>,
Tim Chavez <tinytim@us.ibm.com>,
Jean Pierre Dion <jean-pierre.dion@bull.net>,
Gilles Carry <Gilles.Carry@ext.bull.net>
Subject: Re: [PATCH 2/2][RT] powerpc - Make the irq reverse mapping radix tree lockless
Date: Thu, 24 Jul 2008 21:11:34 +1000 [thread overview]
Message-ID: <200807242111.35338.nickpiggin@yahoo.com.au> (raw)
In-Reply-To: <20080724125044.53b604cb@bull.net>
On Thursday 24 July 2008 20:50, Sebastien Dugue wrote:
> From: Sebastien Dugue <sebastien.dugue@bull.net>
> Date: Tue, 22 Jul 2008 11:56:41 +0200
> Subject: [PATCH][RT] powerpc - Make the irq reverse mapping radix tree
> lockless
>
> The radix tree used by interrupt controllers for their irq reverse
> mapping (currently only the XICS found on pSeries) have a complex locking
> scheme dating back to before the advent of the concurrent radix tree on
> preempt-rt.
>
> Take advantage of this and of the fact that the items of the tree are
> pointers to a static array (irq_map) elements which can never go under us
> to simplify the locking.
>
> Concurrency between readers and writers are handled by the intrinsic
> properties of the concurrent radix tree. Concurrency between the tree
> initialization which is done asynchronously with readers and writers access
> is handled via an atomic variable (revmap_trees_allocated) set when the
> tree has been initialized and checked before any reader or writer access
> just like we used to check for tree.gfp_mask != 0 before.
Hmm, RCU radix tree is in mainline too for quite a while. I thought
Ben had already converted this code over ages ago...
Nothing against the -rt patch, but mainline should probably be updated
to use RCU as well?
next prev parent reply other threads:[~2008-07-24 11:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-24 10:23 [PATCH 0/2][RT] powerpc - fix bug in irq reverse mapping radix tree (Resend) Sebastien Dugue
2008-07-24 10:48 ` [PATCH 1/2][RT] powerpc - XICS: move the call to irq_radix_revmap from xics_startup to xics_host_map Sebastien Dugue
2008-07-24 10:50 ` [PATCH 2/2][RT] powerpc - Make the irq reverse mapping radix tree lockless Sebastien Dugue
2008-07-24 11:11 ` Nick Piggin [this message]
2008-07-24 12:18 ` Sebastien Dugue
2008-07-25 7:49 ` Peter Zijlstra
2008-07-25 8:27 ` Benjamin Herrenschmidt
2008-07-25 8:36 ` Sebastien Dugue
2008-07-25 8:40 ` Benjamin Herrenschmidt
2008-07-25 8:47 ` Sebastien Dugue
2008-07-25 8:34 ` Sebastien Dugue
2008-07-25 5:13 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807242111.35338.nickpiggin@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=Gilles.Carry@ext.bull.net \
--cc=benh@kernel.crashing.org \
--cc=jean-pierre.dion@bull.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
--cc=paulus@samba.org \
--cc=sebastien.dugue@bull.net \
--cc=tinytim@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox