From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755479AbYGXXIQ (ORCPT ); Thu, 24 Jul 2008 19:08:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755218AbYGXXIA (ORCPT ); Thu, 24 Jul 2008 19:08:00 -0400 Received: from mga02.intel.com ([134.134.136.20]:42790 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755214AbYGXXIA (ORCPT ); Thu, 24 Jul 2008 19:08:00 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.31,248,1215414000"; d="scan'208";a="364519569" Date: Thu, 24 Jul 2008 16:06:59 -0700 From: Suresh Siddha To: Linus Torvalds Cc: "Siddha, Suresh B" , "x86@kernel.org" , "andi@firstfloor.org" , Linux Kernel Mailing List , "stable@kernel.org" , Ingo Molnar Subject: Re: [patch] x64, fpu: fix possible FPU leakage in error conditions Message-ID: <20080724230658.GP14380@linux-os.sc.intel.com> References: <20080724180429.GI14380@linux-os.sc.intel.com> <20080724185053.GJ14380@linux-os.sc.intel.com> <20080724202728.GL14380@linux-os.sc.intel.com> <20080724212351.GM14380@linux-os.sc.intel.com> <20080724222523.GN14380@linux-os.sc.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 24, 2008 at 03:43:44PM -0700, Linus Torvalds wrote: > Hmm. In fact, I think that x86-64 version is actually only used in a > single place - arch/x86/kernel/signal_64.c. So it's actively *wrong* to > have that thing in a header file to begin with! BTW, while you are at it, please move save_i387() aswell, to be consistent and clean. thanks, suresh