From: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
To: Ben Dooks <ben-linux@fluff.org>
Cc: Pierre Ossman <drzeus-list@drzeus.cx>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] mmc: Add per-card debugfs support
Date: Fri, 25 Jul 2008 11:05:03 +0200 [thread overview]
Message-ID: <20080725110503.5be65b71@siona.local> (raw)
In-Reply-To: <20080725082424.GD8301@fluff.org.uk>
On Fri, 25 Jul 2008 09:24:24 +0100
Ben Dooks <ben-linux@fluff.org> wrote:
> out of interest, why not have an standard sysfs node for the
> current voltage setting?
Dunno. Because nobody has added it? ;-)
> > Changes since v2:
> > * Don't rely on the compiler to optimize out unused code
>
> which compiler? the gcc 4 series seem quite good at it, gcc 3.4
> and later tended to eliminate only the code and not the associated
> data created with it.
4.2.x. It got rid of the code, the data associated with the code, but
not the code associated with that data again (i.e. the file operations
hooks).
> > +#ifdef CONFIG_DEBUG_FS
> > + mmc_add_card_debugfs(card);
> > +#endif
> > +
>
> why not make mmc_add_card_debugfs() an empty function
> in the header if there is no debugfs support?
Because Pierre didn't like it.
Haavard
next prev parent reply other threads:[~2008-07-25 9:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-24 12:18 [PATCH v3 1/3] mmc: Export internal host state through debugfs Haavard Skinnemoen
2008-07-24 12:18 ` [PATCH v3 2/3] mmc: Add per-card debugfs support Haavard Skinnemoen
2008-07-24 12:18 ` [PATCH v3 3/3] atmel-mci: " Haavard Skinnemoen
2008-07-25 8:24 ` [PATCH v3 2/3] mmc: Add per-card " Ben Dooks
2008-07-25 9:05 ` Haavard Skinnemoen [this message]
2008-07-25 10:05 ` Pierre Ossman
2008-07-26 23:26 ` [PATCH v3 1/3] mmc: Export internal host state through debugfs Pierre Ossman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080725110503.5be65b71@siona.local \
--to=haavard.skinnemoen@atmel.com \
--cc=ben-linux@fluff.org \
--cc=drzeus-list@drzeus.cx \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox