From: David Brownell <david-b@pacbell.net>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Ingo Molnar <mingo@elte.hu>, Greg KH <gregkh@suse.de>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
"Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: [USB boot crash, -git] ecm_do_notify(), list_add corruption. prev->next should be next (ffff88003b8f82f8)
Date: Fri, 25 Jul 2008 18:18:22 -0700 [thread overview]
Message-ID: <200807251818.23046.david-b@pacbell.net> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0807240931220.3494-100000@netrider.rowland.org>
On Thursday 24 July 2008, Alan Stern wrote:
> I think I see the problem. Starting at line 533, we have:
>
> ...
>
> The list_add_tail() gets called at the wrong time if the completion
> routine resubmits. It should look more like this:
>
> ...
>
> Can you make the necessary change and try it out?
It behaved for me, no BUG() ... I'll clean it up and send along a patch.
- Dave
next prev parent reply other threads:[~2008-07-26 1:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-21 22:30 [GIT PATCH] USB patches for 2.6.26 Greg KH
2008-07-22 8:54 ` Benny Halevy
2008-07-22 15:27 ` Greg KH
2008-07-22 13:40 ` [USB boot crash, -git] ecm_do_notify(), list_add corruption. prev->next should be next (ffff88003b8f82f8) Ingo Molnar
2008-07-23 0:10 ` Greg KH
2008-07-23 0:22 ` David Brownell
2008-07-23 23:37 ` David Brownell
2008-07-24 3:46 ` Alan Stern
2008-07-24 7:40 ` David Brownell
2008-07-25 3:57 ` Alan Stern
2008-07-26 1:18 ` David Brownell [this message]
2008-07-26 15:06 ` David Brownell
2008-07-26 15:19 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807251818.23046.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rjw@sisk.pl \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox