From: Nishanth Aravamudan <nacc@us.ibm.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: akpm@linux-foundation.org, torvalds@linux-foundation.org,
mingo@elte.hu, randy.dunlap@oracle.com,
linux-kernel@vger.kernel.org
Subject: [PATCH RESEND] hugetlb: fix CONFIG_SYSCTL=n build
Date: Fri, 25 Jul 2008 13:33:51 -0700 [thread overview]
Message-ID: <20080725203351.GA18407@us.ibm.com> (raw)
In-Reply-To: <20080725180935.5bd02bf5@lxorguk.ukuu.org.uk>
[resending with Linus' address fixed]
On 25.07.2008 [18:09:35 +0100], Alan Cox wrote:
> On Thu, 24 Jul 2008 07:26:03 +0200
> Ingo Molnar <mingo@elte.hu> wrote:
>
> >
> > not sure it's known but despite all the fixes i still get:
> >
> > drivers/built-in.o: In function `ne_drv_resume':
> > ne.c:(.text+0x146ba4): undefined reference to `NS8390_init'
> > drivers/built-in.o: In function `ne_block_output':
> > ne.c:(.text+0x146e00): undefined reference to `NS8390_init'
>
> This should do the trick. I can't test it currently as that configuration
> now fails to build with mm errors in current git head..
>
> mm/hugetlb.c: In function ???hugetlb_acct_memory???: mm/hugetlb.c:1507:
> error: implicit declaration of function ???cpuset_mems_nr???
When moving the intialization functions around, I did not remove the
dependency of some helpers on CONFIG_SYSCTL. This led to a large chunk
of code being elided even though it is needed to build hugetlb.o.
Fixes a build failure reported by Alan Cox:
mm/hugetlb.c: In function âhugetlb_acct_memoryâ: mm/hugetlb.c:1507:
error: implicit declaration of function âcpuset_mems_nrâ
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 41341c4..3be79dc 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -1026,7 +1026,6 @@ static void __init report_hugepages(void)
}
}
-#ifdef CONFIG_SYSCTL
#ifdef CONFIG_HIGHMEM
static void try_to_free_low(struct hstate *h, unsigned long count)
{
@@ -1386,6 +1385,7 @@ static unsigned int cpuset_mems_nr(unsigned int *array)
return nr;
}
+#ifdef CONFIG_SYSCTL
int hugetlb_sysctl_handler(struct ctl_table *table, int write,
struct file *file, void __user *buffer,
size_t *length, loff_t *ppos)
--
Nishanth Aravamudan <nacc@us.ibm.com>
IBM Linux Technology Center
next prev parent reply other threads:[~2008-07-25 20:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-21 14:35 [PATCH] 8390: Fix ne.c build Atsushi Nemoto
2008-07-21 19:15 ` [build failure] hp-plus.c: (.text+0xd7c1a): undefined reference to `ei_close' Ingo Molnar
2008-07-21 20:42 ` Alan Cox
2008-07-22 7:23 ` Ingo Molnar
2008-07-22 10:28 ` Alan Cox
2008-07-22 22:00 ` Jeff Garzik
2008-07-23 10:45 ` Ingo Molnar
2008-07-24 5:26 ` Ingo Molnar
2008-07-24 9:06 ` Alan Cox
2008-07-24 9:29 ` Ingo Molnar
2008-07-24 19:21 ` Jeff Garzik
2008-07-24 19:25 ` Randy.Dunlap
2008-07-24 19:54 ` Alan Cox
2008-07-25 17:09 ` Alan Cox
2008-07-25 18:03 ` [PATCH] hugetlb: fix CONFIG_SYSCTL=n build Nishanth Aravamudan
2008-07-25 20:33 ` Nishanth Aravamudan [this message]
2008-07-25 21:29 ` [PATCH RESEND] " Andrew Morton
2008-07-25 21:52 ` Nishanth Aravamudan
2008-07-26 0:32 ` Linus Torvalds
2008-07-26 0:44 ` Andrew Morton
2008-07-26 1:25 ` Nishanth Aravamudan
2008-07-26 1:52 ` Andrew Morton
2008-07-22 12:24 ` [PATCH] 8390: Fix ne.c build Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080725203351.GA18407@us.ibm.com \
--to=nacc@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=randy.dunlap@oracle.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox