Re: [PATCH] rtc-dev: stop periodic interrupts on device release

David Brownell
2008-07-29T20:08:49Z

On Monday 28 July 2008, Tomáš Janoušek wrote:
> Hello,
>
> On Mon, Jul 28, 2008 at 03:05:36PM -0700, David Brownell wrote:
> > Surely you agree that having the framework shut down only *emulated*
> > update IRQs, not "real" ones, is inconsistent? And hence undesirable?
>
> The idea was that if the "real" ones get turned on using some ioctl magic the
> framework has no exact control over, they shouldn't be shut down by it. But
> yeah, your point of view looks fine as well.

The /dev/rtcN support *is* part of the framework. ;)

> So I guess I'll post the current patch to Andrew and then, someone (not me,
> for time and competence reasons, sorry) can prepare a patch removing the
> release op and changing the calls in framework's release to call
> rtc_dev_ioctl.
>
> Is this ok?

Yep.

- Dave