Re: [PATCH] rtc-dev: stop periodic interrupts on device release

Alessandro Zummo
2008-07-26T18:14:16Z

On Sat, 26 Jul 2008 20:06:10 +0200
Tomáš Janoušek <tomi@nomi.cz> wrote:

> On Sat, Jul 26, 2008 at 07:55:21PM +0200, Alessandro Zummo wrote:
> > I'm not sure this is appropriate. sometimes the PIE is used to control
> > external hardware and it doesn't make sense to have an application that's
> > always open to handle that.
> >
> > Any app should be responsible to release what it has allocated, if appropriate,
> > and not rely on someone else to do on his behalf.
>
> mplayer and aireplay-ng have never done so. And what about crashes? Am I

that's not an excuse, they have been written on a false assumption. Unless
that behaviour is documented somewhere.

> supposed to create a small "rtcpieoff" applications and make it into all
> distributions so that everyone can clean up the mess?

just send patches to mplayer and aireplay-ng and it will make in the distros.

> Additionally, it has been a regression against the old rtc and drivers like
> rtc-sh do so even today.

Specific drivers might choice to do it on close. I believe rtc-cmos might
be one of the few that might have to do it in order to cope with badly
written programs. It's up to David to choice if it's appropriate too add it to
rtc-cmos.

--

Best regards,

Alessandro Zummo,
Tower Technologies - Torino, Italy