From: Andi Kleen <andi@firstfloor.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Dhaval Giani <dhaval@linux.vnet.ibm.com>,
Venkatesch Pallipadi <venkatesh.pallipadi@intel.com>,
Len Brown <lenb@kernel.org>, Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH] ACPI/CPUIDLE: prevent setting pm_idle to NULL
Date: Mon, 28 Jul 2008 19:46:44 +0200 [thread overview]
Message-ID: <20080728174644.GC30344@one.firstfloor.org> (raw)
In-Reply-To: <alpine.LFD.1.10.0807272343480.574@apollo.tec.linutronix.de>
> + /*
> + * Fall back to the default idle loop, when pm_idle_save had
> + * been initialized.
> + */
> + if (pm_idle_save) {
> + pm_idle = pm_idle_save;
> + /* Relies on interrupts forcing exit from idle. */
> + synchronize_sched();
> + }
I think it would be better to fall back to default_idle (which
might need to be exported) when the old pointer is NULL. Now with your patch
the cpuidle idle code would run with inconsistent state for some time,
which is probably not good.
-Andi
next prev parent reply other threads:[~2008-07-28 17:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-27 21:47 [PATCH] ACPI/CPUIDLE: prevent setting pm_idle to NULL Thomas Gleixner
2008-07-28 17:46 ` Andi Kleen [this message]
2008-07-28 19:38 ` Thomas Gleixner
2008-07-28 19:53 ` Andi Kleen
2008-07-28 21:51 ` Thomas Gleixner
2008-07-28 22:05 ` Pallipadi, Venkatesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080728174644.GC30344@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=dhaval@linux.vnet.ibm.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox