public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] omfs: fix sparse signedness warnings
@ 2008-07-29  0:37 Harvey Harrison
  2008-07-29  2:26 ` Bob Copeland
  0 siblings, 1 reply; 2+ messages in thread
From: Harvey Harrison @ 2008-07-29  0:37 UTC (permalink / raw)
  To: Bob Copeland; +Cc: Andrew Morton, LKML

fs/omfs/bitmap.c:74:18: warning: incorrect type in argument 2 (different signedness)
fs/omfs/bitmap.c:74:18:    expected unsigned long volatile *addr
fs/omfs/bitmap.c:74:18:    got long *<noident>
fs/omfs/bitmap.c:77:20: warning: incorrect type in argument 2 (different signedness)
fs/omfs/bitmap.c:77:20:    expected unsigned long volatile *addr
fs/omfs/bitmap.c:77:20:    got long *<noident>
fs/omfs/bitmap.c:112:17: warning: incorrect type in argument 2 (different signedness)
fs/omfs/bitmap.c:112:17:    expected unsigned long volatile *addr
fs/omfs/bitmap.c:112:17:    got long *<noident>

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
Sorry, missed these in my other sparse warning fixes, feel free to fold it
with the other one.

 fs/omfs/bitmap.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/omfs/bitmap.c b/fs/omfs/bitmap.c
index dc75f22..697663b 100644
--- a/fs/omfs/bitmap.c
+++ b/fs/omfs/bitmap.c
@@ -71,10 +71,10 @@ static int set_run(struct super_block *sb, int map,
 		}
 		if (set) {
 			set_bit(bit, sbi->s_imap[map]);
-			set_bit(bit, (long *) bh->b_data);
+			set_bit(bit, (unsigned long *)bh->b_data);
 		} else {
 			clear_bit(bit, sbi->s_imap[map]);
-			clear_bit(bit, (long *) bh->b_data);
+			clear_bit(bit, (unsigned long *)bh->b_data);
 		}
 	}
 	mark_buffer_dirty(bh);
@@ -109,7 +109,7 @@ int omfs_allocate_block(struct super_block *sb, u64 block)
 		if (!bh)
 			goto out;
 
-		set_bit(bit, (long *) bh->b_data);
+		set_bit(bit, (unsigned long *)bh->b_data);
 		mark_buffer_dirty(bh);
 		brelse(bh);
 	}
-- 
1.6.0.rc1.154.ge3fc




^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] omfs: fix sparse signedness warnings
  2008-07-29  0:37 [PATCH] omfs: fix sparse signedness warnings Harvey Harrison
@ 2008-07-29  2:26 ` Bob Copeland
  0 siblings, 0 replies; 2+ messages in thread
From: Bob Copeland @ 2008-07-29  2:26 UTC (permalink / raw)
  To: Harvey Harrison; +Cc: Andrew Morton, LKML

On Mon, Jul 28, 2008 at 05:37:08PM -0700, Harvey Harrison wrote:
> Sorry, missed these in my other sparse warning fixes, feel free to fold it
> with the other one.

Looks good, thanks.

-- 
Bob Copeland %% www.bobcopeland.com


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-07-29  2:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-29  0:37 [PATCH] omfs: fix sparse signedness warnings Harvey Harrison
2008-07-29  2:26 ` Bob Copeland

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox