public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Fries <david@fries.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Subject: [PATCH 29/30] W1: Documentation/w1/masters/ds2490 update
Date: Mon, 28 Jul 2008 21:29:08 -0500	[thread overview]
Message-ID: <20080729022908.GC24452@spacedout.fries.net> (raw)
In-Reply-To: <20080729020433.GA24424@spacedout.fries.net>

[-- Attachment #1: Type: text/plain, Size: 4137 bytes --]

Provide some additional details about the status of the driver and the
ds2490 hardware.

Signed-off-by: David Fries <david@fries.net>
Signed-off-by: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Cc: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
 Documentation/w1/masters/ds2490 |   52 +++++++++++++++++++++++++++++++++++++++
 1 files changed, 52 insertions(+), 0 deletions(-)

diff --git a/Documentation/w1/masters/ds2490 b/Documentation/w1/masters/ds2490
index 239f9ae..28176de 100644
--- a/Documentation/w1/masters/ds2490
+++ b/Documentation/w1/masters/ds2490
@@ -16,3 +16,55 @@ which allows to build USB <-> W1 bridges.
 DS9490(R) is a USB <-> W1 bus master device
 which has 0x81 family ID integrated chip and DS2490
 low-level operational chip.
+
+Notes and limitations.
+- The weak pullup current is a minimum of 0.9mA and maximum of 6.0mA.
+- The 5V strong pullup is supported with a minimum of 5.9mA and a
+  maximum of 30.4 mA.  (From DS2490.pdf)
+- While the ds2490 supports a hardware search the code doesn't take
+  advantage of it (in tested case it only returned first device).
+- The hardware will detect when devices are attached to the bus on the
+  next bus (reset?) operation, however only a message is printed as
+  the core w1 code doesn't make use of the information.  Connecting
+  one device tends to give multiple new device notifications.
+- The number of USB bus transactions could be reduced if w1_reset_send
+  was added to the API.  The name is just a suggestion.  It would take
+  a write buffer and a read buffer (along with sizes) as arguments.
+  The ds2490 block I/O command supports reset, write buffer, read
+  buffer, and strong pullup all in one command, instead of the current
+  1 reset bus, 2 write the match rom command and slave rom id, 3 block
+  write and read data.  The write buffer needs to have the match rom
+  command and slave rom id prepended to the front of the requested
+  write buffer, both of which are known to the driver.
+- The hardware supports normal, flexible, and overdrive bus
+  communication speeds, but only the normal is supported.
+- The registered w1_bus_master functions don't define error
+  conditions.  If a bus search is in progress and the ds2490 is
+  removed it can produce a good amount of error output before the bus
+  search finishes.
+- The hardware supports detecting some error conditions, such as
+  short, alarming presence on reset, and no presence on reset, but the
+  driver doesn't query those values.
+- The ds2490 specification doesn't cover short bulk in reads in
+  detail, but my observation is if fewer bytes are requested than are
+  available, the bulk read will return an error and the hardware will
+  clear the entire bulk in buffer.  It would be possible to read the
+  maximum buffer size to not run into this error condition, only extra
+  bytes in the buffer is a logic error in the driver.  The code should
+  should match reads and writes as well as data sizes.  Reads and
+  writes are serialized and the status verifies that the chip is idle
+  (and data is available) before the read is executed, so it should
+  not happen.
+- Running x86_64 2.6.24 UHCI under qemu 0.9.0 under x86_64 2.6.22-rc6
+  with a OHCI controller, ds2490 running in the guest would operate
+  normally the first time the module was loaded after qemu attached
+  the ds2490 hardware, but if the module was unloaded, then reloaded
+  most of the time one of the bulk out or in, and usually the bulk in
+  would fail.  qemu sets a 50ms timeout and the bulk in would timeout
+  even when the status shows data available.  A bulk out write would
+  show a successful completion, but the ds2490 status register would
+  show 0 bytes written.  Detaching qemu from the ds2490 hardware and
+  reattaching would clear the problem.  usbmon output in the guest and
+  host did not explain the problem.  My guess is a bug in either qemu
+  or the host OS and more likely the host OS.
+-- 03-06-2008 David Fries <David@Fries.net>
-- 
1.4.4.4

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

  parent reply	other threads:[~2008-07-29  2:29 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-29  2:04 [PATCH 0/30] W1: w1 core fixes, ds2490 updates, strong pullup David Fries
2008-07-29  2:10 ` [PATCH 1/30] W1: fix deadlocks and remove w1_control_thread David Fries
2008-07-29  2:12 ` [PATCH 2/30] W1: abort search early on on exit David Fries
2008-07-29  2:13 ` [PATCH 3/30] W1: don't delay search start David Fries
2008-07-29  2:14 ` [PATCH 4/30] W1: w1_process, block or sleep David Fries
2008-07-29  2:14 ` [PATCH 5/30] W1: feature, enable hardware strong pullup David Fries
2008-07-29 23:21   ` Andrew Morton
2008-07-29  2:15 ` [PATCH 6/30] W1: feature, w1_therm.c use strong pullup and documentation David Fries
2008-07-29  2:17 ` [PATCH 7/30] W1: be able to manually add and remove slaves David Fries
2008-07-29  2:18 ` [PATCH 8/30] W1: recode w1_slave_found logic David Fries
2008-07-29  2:19 ` [PATCH 9/30] W1: new module parameter search_count David Fries
2008-07-29  2:20 ` [PATCH 10/30] W1: Document add, remove, search_count, and pullup David Fries
2008-07-29  2:21 ` [PATCH 11/30] W1: w1_slave_read_id read bug, use device_attribute David Fries
2008-07-29  2:21 ` [PATCH 12/30] W1: w1_therm fix user buffer overflow and cat David Fries
2008-07-29  2:21 ` [PATCH 13/30] W1: w1_family, remove unused variable need_exit David Fries
2008-07-29  2:22 ` [PATCH 14/30] W1: w1_therm consistent mutex access code cleanup David Fries
2008-07-29  2:23 ` [PATCH 15/30] W1: w1_int.c use first available master number David Fries
2008-07-29  2:23 ` [PATCH 16/30] W1: w1.c s/printk/dev_dbg/ David Fries
2008-07-29  2:24 ` [PATCH 17/30] W1: w1_io.c reset comments and msleep David Fries
2008-07-29  2:24 ` [PATCH 18/30] W1: ds1wm.c msleep for reset David Fries
2008-07-29  2:25 ` [PATCH 19/30] W1: ds2490.c correct print message David Fries
2008-07-29  2:25 ` [PATCH 20/30] W1: ds2490.c add support for strong pullup David Fries
2008-07-29  2:25 ` [PATCH 21/30] W1: ds2490.c ds_write_bit, grouping error, disable readback David Fries
2008-07-29  2:25 ` [PATCH 22/30] W1: ds2490.c disable bit read and write David Fries
2008-07-29  2:26 ` [PATCH 23/30] W1: ds2490.c simplify and fix ds_touch_bit David Fries
2008-07-29  2:26 ` [PATCH 24/30] W1: ds2490.c ds_dump_status rework David Fries
2008-07-29  2:26 ` [PATCH 25/30] W1: ds2490.c ds_reset remove ds_wait_status David Fries
2008-07-29  2:27 ` [PATCH 26/30] W1: ds2490.c reset ds2490 in init David Fries
2008-07-29  2:28 ` [PATCH 27/30] W1: ds2490.c magic number work David Fries
2008-07-29  2:28 ` [PATCH 28/30] W1: ds2490.c ds_write_block remove extra ds_wait_status David Fries
2008-07-29  2:29 ` David Fries [this message]
2008-07-29  2:30 ` [PATCH 30/30] W1: ds2490.c optimize ds_set_pullup David Fries
2008-07-29 23:13 ` [PATCH 0/30] W1: w1 core fixes, ds2490 updates, strong pullup Andrew Morton
2008-07-31  2:37   ` David Fries
2008-07-31  3:03     ` Andrew Morton
2008-07-31  2:47   ` [PATCH 1/30] W1: fix deadlocks and remove w1_control_thread David Fries
2008-07-31  2:48   ` [PATCH 2/30] W1: abort search early on on exit David Fries
2008-07-31  2:48   ` [PATCH 3/30] W1: don't delay search start David Fries
2008-07-31  2:48   ` [PATCH 4/30] W1: w1_process, block or sleep David Fries
2008-07-31  2:48   ` [PATCH 5/30] W1: feature, enable hardware strong pullup David Fries
2008-07-31  2:48   ` [PATCH 6/30] W1: feature, w1_therm.c use strong pullup and documentation David Fries
2008-07-31  2:48   ` [PATCH 7/30] W1: be able to manually add and remove slaves David Fries
2008-07-31  2:48   ` [PATCH 8/30] W1: recode w1_slave_found logic David Fries
2008-07-31  2:48   ` [PATCH 9/30] W1: new module parameter search_count David Fries
2008-07-31  2:49   ` [PATCH 10/30] W1: Document add, remove, search_count, and pullup David Fries
2008-07-31  2:49   ` [PATCH 11/30] W1: w1_slave_read_id read bug, use device_attribute David Fries
2008-07-31  2:49   ` [PATCH 12/30] W1: w1_therm fix user buffer overflow and cat David Fries
2008-07-31  2:49   ` [PATCH 13/30] W1: w1_family, remove unused variable need_exit David Fries
2008-07-31  2:49   ` [PATCH 14/30] W1: w1_therm consistent mutex access code cleanup David Fries
2008-07-31  2:49   ` [PATCH 15/30] W1: w1_int.c use first available master number David Fries
2008-07-31  2:49   ` [PATCH 16/30] W1: w1.c s/printk/dev_dbg/ David Fries
2008-07-31  2:49   ` [PATCH 17/30] W1: w1_io.c reset comments and msleep David Fries
2008-07-31  2:49   ` [PATCH 18/30] W1: ds1wm.c msleep for reset David Fries
2008-07-31  2:49   ` [PATCH 19/30] W1: ds2490.c correct print message David Fries
2008-07-31  2:49   ` [PATCH 20/30] W1: ds2490.c add support for strong pullup David Fries
2008-07-31  2:50   ` [PATCH 21/30] W1: ds2490.c ds_write_bit, grouping error, disable readback David Fries
2008-07-31  2:50   ` [PATCH 22/30] W1: ds2490.c disable bit read and write David Fries
2008-07-31  2:50   ` [PATCH 23/30] W1: ds2490.c simplify and fix ds_touch_bit David Fries
2008-07-31  2:50   ` [PATCH 24/30] W1: ds2490.c ds_dump_status rework David Fries
2008-07-31  2:50   ` [PATCH 25/30] W1: ds2490.c ds_reset remove ds_wait_status David Fries
2008-07-31  2:50   ` [PATCH 26/30] W1: ds2490.c reset ds2490 in init David Fries
2008-07-31  2:50   ` [PATCH 27/30] W1: ds2490.c magic number work David Fries
2008-07-31  2:50   ` [PATCH 28/30] W1: ds2490.c ds_write_block remove extra ds_wait_status David Fries
2008-07-31  2:50   ` [PATCH 29/30] W1: Documentation/w1/masters/ds2490 update David Fries
2008-07-31  2:50   ` [PATCH 30/30] W1: ds2490.c optimize ds_set_pullup David Fries
  -- strict thread matches above, loose matches on Subject: below --
2008-07-11 13:51 w1 updates Evgeniy Polyakov
2008-07-11 13:51 ` [PATCH 29/30] W1: Documentation/w1/masters/ds2490 update Evgeniy Polyakov
2008-07-14 20:40   ` Randy Dunlap
2008-07-15  2:16     ` David Fries
2008-07-17 21:52       ` Randy Dunlap
2008-07-15  2:17     ` David Fries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080729022908.GC24452@spacedout.fries.net \
    --to=david@fries.net \
    --cc=akpm@linux-foundation.org \
    --cc=johnpol@2ka.mipt.ru \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox