From: Rusty Russell <rusty@rustcorp.com.au>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Matthew Wilcox <matthew@wil.cx>,
"Randy.Dunlap" <rdunlap@xenotime.net>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Hellwig <hch@infradead.org>
Subject: [PATCH] Introduce down_try() so we can move away from down_trylock()
Date: Tue, 29 Jul 2008 10:15:02 +1000 [thread overview]
Message-ID: <200807291015.02865.rusty@rustcorp.com.au> (raw)
I planned on removing the much-disliked down_trylock() (with its
backwards return codes) in 2.6.27, but it's creating something of a
logjam with other patches in -mm and linux-next.
Andrew suggested introducing "down_try" as a wrapper now, to make
the transition easier. Linus, please apply.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Matthew Wilcox <matthew@wil.cx>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
---
include/linux/semaphore.h | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff -r 92664ae4130b include/linux/semaphore.h
--- a/include/linux/semaphore.h Wed May 21 14:54:40 2008 +1000
+++ b/include/linux/semaphore.h Wed May 21 15:07:31 2008 +1000
@@ -48,4 +48,18 @@ extern int __must_check down_timeout(str
extern int __must_check down_timeout(struct semaphore *sem, long jiffies);
extern void up(struct semaphore *sem);
+/**
+ * down_try - try to down a semaphore, but don't block
+ * @sem: the semaphore
+ *
+ * This is equivalent to down_trylock(), but has the same return codes as
+ * spin_trylock and mutex_trylock: 1 if semaphore acquired, 0 if not.
+ *
+ * down_trylock() with its confusing return codes will be deprecated
+ * soon. It will not be missed.
+ */
+static inline int __must_check down_try(struct semaphore *sem)
+{
+ return !down_trylock(sem);
+}
#endif /* __LINUX_SEMAPHORE_H */
next reply other threads:[~2008-07-29 0:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-29 0:15 Rusty Russell [this message]
2008-07-29 0:27 ` [PATCH] Introduce down_try() so we can move away from down_trylock() Paul Menage
2008-07-29 13:01 ` Rusty Russell
2008-07-29 16:21 ` Randy Dunlap
2008-07-29 23:56 ` Rusty Russell
2008-08-01 17:26 ` Linus Torvalds
2008-08-01 17:40 ` Andrew Morton
2008-08-01 18:22 ` Linus Torvalds
2008-08-03 8:33 ` Rusty Russell
2008-08-03 13:07 ` Matthew Wilcox
2008-08-03 17:33 ` Linus Torvalds
2008-08-03 17:35 ` Linus Torvalds
2008-08-04 3:28 ` Rusty Russell
2008-08-04 5:53 ` Linus Torvalds
2008-08-04 7:57 ` Rusty Russell
2008-08-04 8:45 ` Alan Cox
2008-08-04 11:43 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807291015.02865.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=rdunlap@xenotime.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox