From: Ingo Molnar <mingo@elte.hu>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: davem@davemloft.net, joerg.roedel@amd.com, sfr@canb.auug.org.au,
mingo@redhat.com, tglx@linutronix.de,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
bhavna.sarathy@amd.com, robert.richter@amd.com,
torvalds@linux-foundation.org, akpm@linux-foundation.org,
jbarnes@virtuousgeek.org, linux-next@vger.kernel.org
Subject: Re: [PATCH] add iommu_num_pages helper function
Date: Tue, 29 Jul 2008 12:31:46 +0200 [thread overview]
Message-ID: <20080729103146.GA32407@elte.hu> (raw)
In-Reply-To: <20080729192834M.fujita.tomonori@lab.ntt.co.jp>
* FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> wrote:
> On Tue, 29 Jul 2008 03:10:05 -0700 (PDT)
> David Miller <davem@davemloft.net> wrote:
>
> > From: Joerg Roedel <joerg.roedel@amd.com>
> > Date: Tue, 29 Jul 2008 11:50:27 +0200
> >
> > > I think moving that function to x86-only code is the best solution for
> > > now. Before moving it back to generic code we need an architecture
> > > independent way to find out the IOMMU page size.
> >
> > My suggestion (again) is to pass it in as a "const unsigned long
> > io_page_size" argument and update the callers.
>
> Either is fine by me.
>
> Joerg, if you like, please finish this (for all the architectures,
> please). As I said before, I planed to work on this cleanup after rc1
> (and this should have been 2.6.28 stuff). But I'd appreciate if you
> would do.
i've queued up your quick fix in tip/x86/urgent to resolve the immediate
-git build breakage. The wider patch can then be done on top of that,
without being rushed. Any objections to this approach?
Ingo
next prev parent reply other threads:[~2008-07-29 10:32 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-25 12:57 [PATCH 0/3] IOMMU: move page number calculation to generic code Joerg Roedel
2008-07-25 12:57 ` [PATCH] add iommu_num_pages helper function Joerg Roedel
2008-07-25 13:15 ` FUJITA Tomonori
2008-07-25 13:21 ` Joerg Roedel
2008-07-25 13:34 ` FUJITA Tomonori
2008-07-25 13:41 ` Joerg Roedel
2008-07-25 13:57 ` FUJITA Tomonori
2008-07-25 14:14 ` Joerg Roedel
2008-07-25 14:32 ` FUJITA Tomonori
2008-07-26 13:41 ` Ingo Molnar
2008-07-29 1:07 ` Stephen Rothwell
2008-07-29 1:46 ` FUJITA Tomonori
2008-07-29 3:56 ` Stephen Rothwell
2008-07-29 4:38 ` FUJITA Tomonori
2008-07-29 5:26 ` David Miller
2008-07-29 5:42 ` FUJITA Tomonori
2008-07-29 5:24 ` David Miller
2008-07-29 5:42 ` FUJITA Tomonori
2008-07-29 6:45 ` Stephen Rothwell
2008-07-29 9:50 ` Joerg Roedel
2008-07-29 9:58 ` FUJITA Tomonori
2008-07-29 10:02 ` Joerg Roedel
2008-07-30 22:44 ` Benjamin Herrenschmidt
2008-07-31 2:07 ` FUJITA Tomonori
2008-07-29 10:10 ` David Miller
2008-07-29 10:26 ` Joerg Roedel
2008-07-29 10:27 ` FUJITA Tomonori
2008-07-29 10:31 ` Ingo Molnar [this message]
2008-07-29 10:33 ` David Miller
2008-07-29 12:45 ` Stephen Rothwell
2008-07-30 12:18 ` Joerg Roedel
2008-07-30 13:16 ` FUJITA Tomonori
2008-07-30 14:03 ` Joerg Roedel
2008-07-30 18:52 ` Joerg Roedel
2008-07-30 22:44 ` Benjamin Herrenschmidt
2008-07-29 11:27 ` Ingo Molnar
2008-07-29 15:45 ` Jesse Barnes
2008-07-25 12:57 ` [PATCH] AMD IOMMU: replace to_pages macro with iommu_num_pages Joerg Roedel
2008-07-25 12:58 ` [PATCH] x86 gart: " Joerg Roedel
2008-07-26 13:44 ` [PATCH 0/3] IOMMU: move page number calculation to generic code Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080729103146.GA32407@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=bhavna.sarathy@amd.com \
--cc=davem@davemloft.net \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=iommu@lists.linux-foundation.org \
--cc=jbarnes@virtuousgeek.org \
--cc=joerg.roedel@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=robert.richter@amd.com \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox