From: David Miller <davem@davemloft.net>
To: mikpe@it.uu.se
Cc: linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org
Subject: Re: [PATCH 2.6.27-rc1] sparc64: FUTEX_OP_ANDN fix
Date: Wed, 30 Jul 2008 15:40:17 -0700 (PDT) [thread overview]
Message-ID: <20080730.154017.10423102.davem@davemloft.net> (raw)
In-Reply-To: <200807302214.m6UMEw7l000936@harpo.it.uu.se>
From: Mikael Pettersson <mikpe@it.uu.se>
Date: Thu, 31 Jul 2008 00:14:58 +0200 (MEST)
> Correct sparc64's implementation of FUTEX_OP_ANDN to do a
> bitwise negate of the oparg parameter before applying the
> AND operation. All other archs that support FUTEX_OP_ANDN
> either negate oparg explicitly (frv, ia64, mips, sh, x86),
> or do so indirectly by using an and-not instruction (powerpc).
> Since sparc64 has and-not, I chose to use that solution.
>
> I've not found any use of FUTEX_OP_ANDN in glibc so the
> impact of this bug is probably minor. But other user-space
> components may try to use it so it should still get fixed.
>
> Signed-off-by: Mikael Pettersson <mikpe@it.uu.se>
Thanks a lot for this fix, I'll apply it!
prev parent reply other threads:[~2008-07-30 22:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-30 22:14 [PATCH 2.6.27-rc1] sparc64: FUTEX_OP_ANDN fix Mikael Pettersson
2008-07-30 22:40 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080730.154017.10423102.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mikpe@it.uu.se \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox