From: Andi Kleen <andi@firstfloor.org>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Ingo Molnar <mingo@elte.hu>,
Nick Piggin <nickpiggin@yahoo.com.au>,
Andi Kleen <andi@firstfloor.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] x86: implement multiple queues for smp function call IPIs
Date: Wed, 30 Jul 2008 02:13:58 +0200 [thread overview]
Message-ID: <20080730001358.GA23938@one.firstfloor.org> (raw)
In-Reply-To: <488FA8A9.6000005@goop.org>
On Tue, Jul 29, 2008 at 04:32:57PM -0700, Jeremy Fitzhardinge wrote:
> This adds 8 queues for smp_call_function(), in order to avoid a
Now that we have per CPU IDT and there's no global bottleneck anymore
I think it would be actually fine to use
more than 8 vectors. 32 or 64 might be a better default.
> void native_send_call_func_ipi(cpumask_t mask)
> {
> cpumask_t allbutself;
> + unsigned queue = smp_processor_id() % CONFIG_GENERIC_SMP_QUEUES;
Does this really always run with preemption disabled?
Did I miss it but where is the per vector lock?
-Andi
next prev parent reply other threads:[~2008-07-30 0:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-29 23:32 [PATCH 2/2] x86: implement multiple queues for smp function call IPIs Jeremy Fitzhardinge
2008-07-29 23:43 ` Jeremy Fitzhardinge
2008-07-30 0:13 ` Andi Kleen [this message]
2008-07-30 0:44 ` Jeremy Fitzhardinge
2008-07-30 4:55 ` Nick Piggin
2008-07-31 22:08 ` Ingo Molnar
2008-07-31 22:12 ` Andi Kleen
2008-07-31 22:23 ` Jeremy Fitzhardinge
2008-07-31 22:42 ` Ingo Molnar
2008-08-01 4:58 ` Jeremy Fitzhardinge
2008-08-01 9:09 ` Ingo Molnar
2008-08-01 14:17 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080730001358.GA23938@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox