From: Sam Ravnborg <sam@ravnborg.org>
To: petkovbb@gmail.com, Randy Dunlap <rdunlap@xenotime.net>,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH 1/5] docsrc: build Documentation/ sources
Date: Wed, 30 Jul 2008 10:44:05 +0200 [thread overview]
Message-ID: <20080730084405.GD18366@uranus.ravnborg.org> (raw)
In-Reply-To: <20080729202732.GB6007@gollum.tnic>
On Tue, Jul 29, 2008 at 10:27:32PM +0200, Borislav Petkov wrote:
> On Tue, Jul 29, 2008 at 01:05:15PM -0700, Randy Dunlap wrote:
> > From: Randy Dunlap <randy.dunlap@oracle.com>
> >
> > Currently source files in the Documentation/ sub-dir can easily bit-rot
> > since they are not generally buildable, either because they are hidden
> > in text files or because there are no Makefile rules for them.
> > This needs to be fixed so that the source files remain usable and good
> > examples of code instead of bad examples.
> >
> > Add the ability to build source files that are in the Documentation/ dir.
> > Add to Kconfig as "BUILD_DOCSRC" config symbol.
> >
> > Use "CONFIG_BUILD_DOCSRC=1 make ..." to build objects from the
> > Documentation/ sources. Or enable BUILD_DOCSRC in the *config system.
>
> How about simply adding another makefile target instead? This is more
> intuitive, imho, and complies with the Kbuild conventions so far.
> Something like:
>
> make docsrc
>
> similar to 'make help' or 'make pdfdocs' etc.
With the current approach we have much better build coverage.
All "allyesconfig" and "allmodconfig" builds will do the test
builds which is a good think.
If we introduce "make docsrc" then almost only Randy will do the
test builds and report the breakage - which is not good.
Sam
next prev parent reply other threads:[~2008-07-30 8:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-29 20:05 [PATCH 1/5] docsrc: build Documentation/ sources Randy Dunlap
2008-07-29 20:05 ` [PATCH 4/5] docsrc: fix crc32hash type Randy Dunlap
2008-07-30 6:47 ` Dominik Brodowski
2008-07-30 7:18 ` Andrew Morton
2008-07-30 8:40 ` Sam Ravnborg
2008-07-29 20:05 ` [PATCH 2/5] docsrc: fix procfs example Randy Dunlap
2008-07-29 20:05 ` [PATCH 5/5] docsrc: fix getdelays printk formats Randy Dunlap
2008-07-29 20:05 ` [PATCH 3/5] docsrc: fix ifenslave type Randy Dunlap
2008-07-29 20:27 ` [PATCH 1/5] docsrc: build Documentation/ sources Borislav Petkov
2008-07-29 21:10 ` Randy Dunlap
2008-07-30 8:44 ` Sam Ravnborg [this message]
2008-07-30 8:55 ` Boris Petkov
2008-07-30 11:21 ` Sam Ravnborg
2008-07-30 12:22 ` Boris Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080730084405.GD18366@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=petkovbb@gmail.com \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox