From: Karsten Keil <kkeil@suse.de>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Karsten Keil <kkeil@suse.de>,
isdn4linux@listserv.isdn4linux.de,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mISDN cleanup user interface
Date: Wed, 30 Jul 2008 17:08:20 +0200 [thread overview]
Message-ID: <20080730150820.GA9491@pingi.kke.suse.de> (raw)
In-Reply-To: <1217362946.27925.137.camel@pmac.infradead.org>
On Tue, Jul 29, 2008 at 09:22:26PM +0100, David Woodhouse wrote:
> On Tue, 2008-07-29 at 21:56 +0200, Karsten Keil wrote:
> > Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/kkeil/ISDN-2.6.git master
> >
> > The channelmap should have the same size on 32 and 64 bit
> > systems. Thanks to David Woodhouse for spotting this.
> >
> > Signed-off-by: Karsten Keil <kkeil@suse.de>
>
> Er, isn't that still broken? Consider 32-bit userspace on 64-bit kernel,
> big-endian.
>
URGH, you are right, using the bit operations here is not a good idea at
all and currently we also need not to be atomic for this map so we can use a
bytearray and simple operation here.
--
Karsten Keil
SuSE Labs
ISDN and VOIP development
SUSE LINUX Products GmbH, Maxfeldstr.5 90409 Nuernberg, GF: Markus Rex, HRB 16746 (AG Nuernberg)
next prev parent reply other threads:[~2008-07-30 15:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-29 19:56 [PATCH] mISDN cleanup user interface Karsten Keil
2008-07-29 20:22 ` David Woodhouse
2008-07-29 21:02 ` Marcel Holtmann
2008-07-30 9:13 ` David Woodhouse
2008-07-30 16:33 ` Karsten Keil
2008-07-30 16:57 ` David Woodhouse
2008-07-30 17:51 ` Karsten Keil
2008-07-30 18:37 ` Sam Ravnborg
2008-07-30 18:46 ` Karsten Keil
2008-07-30 19:08 ` David Woodhouse
2008-07-30 15:08 ` Karsten Keil [this message]
2008-08-01 17:21 ` Linus Torvalds
2008-08-02 15:21 ` Karsten Keil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080730150820.GA9491@pingi.kke.suse.de \
--to=kkeil@suse.de \
--cc=dwmw2@infradead.org \
--cc=isdn4linux@listserv.isdn4linux.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox