From: Andrew Morton <akpm@linux-foundation.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] ftrace: dump out ftrace buffers to console on panic
Date: Wed, 30 Jul 2008 17:56:40 -0700 [thread overview]
Message-ID: <20080730175640.f04f81b5.akpm@linux-foundation.org> (raw)
In-Reply-To: <alpine.DEB.1.10.0807302020590.19138@gandalf.stny.rr.com>
On Wed, 30 Jul 2008 20:39:47 -0400 (EDT) Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> >> + __raw_spin_lock(&ftrace_dump_lock);
> >> + dump_running = 0;
> >> + __raw_spin_unlock(&ftrace_dump_lock);
> >> +
> >> + out:
> >> + local_irq_restore(flags);
> >> +}
> >> +#endif /* CONFIG_FTRACE_DUMP_ON_OOPS */
> >
> > Do we really need a new config option for this? Would it hurt too much
> > to make it unconditionally available?
>
> I don't mind making it unconditionally available. I only added the config
> option because I thought people would like to turn it off.
>
> I'll resubmit with the above concerns fixed and without the config option.
Well.. my question about the config option was no more than a question
- I don't know the answer.
Although thinking about it, I guess that anyone who is really squeezy
on space just won't be enabling ftrace at all. Is there any reason
other than size for disabling this new feature?
next prev parent reply other threads:[~2008-07-31 0:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-30 21:13 [PATCH] ftrace: dump out ftrace buffers to console on panic Steven Rostedt
2008-07-30 21:30 ` Andrew Morton
2008-07-31 0:39 ` Steven Rostedt
2008-07-31 0:56 ` Andrew Morton [this message]
2008-07-31 1:05 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080730175640.f04f81b5.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox