From: Dave Jones <davej@codemonkey.org.uk>
To: Mike Travis <travis@sgi.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Rusty Russell <rusty@rustcorp.com.au>,
Andrew Morton <akpm@linux-foundation.org>,
"H. Peter Anvin" <hpa@zytor.com>, Jack Steiner <steiner@sgi.com>,
Christoph Lameter <cl@linux-foundation.org>,
linux-kernel@vger.kernel.org, Len Brown <len.brown@intel.com>,
Lennert Buytenhek <kernel@wantstofly.org>,
Paul Jackson <pj@sgi.com>, Tony Luck <tony.luck@intel.com>,
Tigran Aivazian <tigran@aivazian.fsnet.co.uk>,
Paul Mackerras <paulus@samba.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Robert Richter <robert.richter@amd.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Sam Creasey <sammy@sammy.net>, Greg Banks <gnb@sgi.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Adrian Bunk <bunk@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Andreas Schwab <schwab@suse.de>,
Johannes Weiner <hannes@saeurebad.de>
Subject: Re: [PATCH 1/1] cpumask: Change cpumask_of_cpu to use cpumask_of_cpu_map
Date: Wed, 30 Jul 2008 14:50:03 -0400 [thread overview]
Message-ID: <20080730185003.GA18162@codemonkey.org.uk> (raw)
In-Reply-To: <4890B500.7040100@sgi.com>
On Wed, Jul 30, 2008 at 11:37:52AM -0700, Mike Travis wrote:
> >> I've lost the plot on what's going on with these cpumask patches.
> >> But I just saw this on -rc1.
> >>
> >> arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c:206:33: error: not addressable
> >> arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c:274:32: error: not addressable
> >> arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c:352:34: error: not addressable
> >>
>
> After I recreated linux-next the changes all appear to be there now.
> One problem though, is !SMP config does not build (something about
> DECLARE_BITMAP with NR_CPUS=1.) I wasn't sure how to create a constant
> "(cpumask_t)1" that worked as an lvalue, so the following patch is
> somewhat a kluge, but fulfills the requirements.
>
> If anyone has a better suggestion, please let me know.
>
> Subject: [PATCH] cpmask: add cpumask_of_cpu(0) for non-SMP
>
> * Fix cpumask_of_cpu(0) when CONFIG_SMP is not set by providing a
> pointer to a cpumask_t with cpu 0 bit set.
confused. I saw the error above with a make allyesconfig, which
sets CONFIG_SMP=y
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2008-07-30 18:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-23 17:18 [PATCH 0/1] cpumask: Change cpumask_of_cpu to use cpumask_of_cpu_map Mike Travis
2008-07-23 17:18 ` [PATCH 1/1] " Mike Travis
2008-07-24 2:45 ` Rusty Russell
2008-07-24 17:56 ` Mike Travis
2008-07-25 0:37 ` Mike Travis
2008-07-24 11:46 ` Ingo Molnar
2008-07-24 17:11 ` Mike Travis
2008-07-24 19:12 ` Mike Travis
2008-07-24 12:56 ` Bert Wesarg
2008-07-24 17:15 ` Mike Travis
2008-07-25 0:27 ` Mike Travis
2008-07-25 1:26 ` Paul Jackson
2008-07-30 16:55 ` Dave Jones
2008-07-30 17:11 ` Mike Travis
2008-07-30 18:37 ` Mike Travis
2008-07-30 18:50 ` Dave Jones [this message]
2008-07-30 19:25 ` Mike Travis
2008-07-30 19:50 ` Dave Jones
2008-07-30 20:02 ` [PATCH 1/1] cpumask: Change cpumask_of_cpu to use cpumask_of_cpu_map - build breakage Tim Bird
2008-07-30 21:24 ` Mike Travis
2008-07-30 22:03 ` Tim Bird
2008-07-30 23:48 ` Stephen Rothwell
2008-07-31 0:11 ` Tim Bird
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080730185003.GA18162@codemonkey.org.uk \
--to=davej@codemonkey.org.uk \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=bunk@kernel.org \
--cc=cl@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=gnb@sgi.com \
--cc=hannes@saeurebad.de \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=kernel@wantstofly.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=pj@sgi.com \
--cc=robert.richter@amd.com \
--cc=rusty@rustcorp.com.au \
--cc=sammy@sammy.net \
--cc=schwab@suse.de \
--cc=schwidefsky@de.ibm.com \
--cc=steiner@sgi.com \
--cc=tglx@linutronix.de \
--cc=tigran@aivazian.fsnet.co.uk \
--cc=tony.luck@intel.com \
--cc=travis@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox