From: Yinghai Lu <yhlu.kernel@gmail.com>
To: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Dhaval Giani <dhaval@linux.vnet.ibm.com>,
Mike Travis <travis@sgi.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] serial: change remove NR_IRQS in 8250.c
Date: Thu, 31 Jul 2008 01:26:12 -0700 [thread overview]
Message-ID: <200807310126.12572.yhlu.kernel@gmail.com> (raw)
In-Reply-To: <200807302110.10585.yhlu.kernel@gmail.com>
replace
[PATCH] serial: change irq_lists to use dyn_array
use small array with index to handle irq locking for serial port
hope 32 slot is enough
Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
---
drivers/serial/8250.c | 73 +++++++++++++++++++++++++++++++++++++++++++++-----
1 file changed, 67 insertions(+), 6 deletions(-)
Index: linux-2.6/drivers/serial/8250.c
===================================================================
--- linux-2.6.orig/drivers/serial/8250.c
+++ linux-2.6/drivers/serial/8250.c
@@ -149,7 +149,55 @@ struct irq_info {
struct list_head *head;
};
-static struct irq_info irq_lists[NR_IRQS];
+struct irq_info_pair {
+ struct irq_info irq_info;
+ int irq_no;
+};
+
+#define NR_IRQ_INFO_PAIR 32
+
+static struct irq_info_pair irq_pair_lists[NR_IRQ_INFO_PAIR] = {
+ [0 ... NR_IRQ_INFO_PAIR-1] = {
+ .irq_no = -1,
+ }
+};
+
+static struct irq_info *get_irq_info(int irq, int with_free)
+{
+ int i, first_free = -1;
+
+ for (i = 0; i < NR_IRQ_INFO_PAIR; i++) {
+ if (irq_pair_lists[i].irq_no == irq)
+ return &irq_pair_lists[i].irq_info;
+ if (irq_pair_lists[i].irq_no == -1 && first_free == -1)
+ first_free = i;
+ }
+ if (!with_free)
+ return NULL;
+
+ if (first_free != -1) {
+ irq_pair_lists[first_free].irq_no = irq;
+ return &irq_pair_lists[first_free].irq_info;
+ }
+
+ WARN_ON("NR_IRQ_INFO_PAIR too small");
+
+ return NULL;
+}
+
+static void check_free_irq_info(int irq_no)
+{
+
+ int i;
+
+ for (i = 0; i < NR_IRQ_INFO_PAIR; i++) {
+ if (irq_pair_lists[i].irq_no != irq_no)
+ continue;
+
+ irq_pair_lists[i].irq_no = -1;
+ break;
+ }
+}
/*
* Here we define the default xmit fifo size used for each type of UART.
@@ -1554,9 +1602,12 @@ static void serial_do_unlink(struct irq_
static int serial_link_irq_chain(struct uart_8250_port *up)
{
- struct irq_info *i = irq_lists + up->port.irq;
+ struct irq_info *i = get_irq_info(up->port.irq, 1);
int ret, irq_flags = up->port.flags & UPF_SHARE_IRQ ? IRQF_SHARED : 0;
+ if (!i)
+ return -1;
+
spin_lock_irq(&i->lock);
if (i->head) {
@@ -1580,14 +1631,24 @@ static int serial_link_irq_chain(struct
static void serial_unlink_irq_chain(struct uart_8250_port *up)
{
- struct irq_info *i = irq_lists + up->port.irq;
+ int irq_no = up->port.irq;
+ struct irq_info *i = get_irq_info(irq_no, 0);
+ int empty = 0;
+
+ if (!i)
+ return;
BUG_ON(i->head == NULL);
- if (list_empty(i->head))
+ if (list_empty(i->head)) {
free_irq(up->port.irq, i);
+ empty = 1;
+ }
serial_do_unlink(i, up);
+
+ if (empty)
+ check_free_irq_info(irq_no);
}
/* Base timer interval for polling */
@@ -2964,8 +3025,8 @@ static int __init serial8250_init(void)
"%d ports, IRQ sharing %sabled\n", nr_uarts,
share_irqs ? "en" : "dis");
- for (i = 0; i < nr_irqs; i++)
- spin_lock_init(&irq_lists[i].lock);
+ for (i = 0; i < NR_IRQ_INFO_PAIR; i++)
+ spin_lock_init(&irq_pair_lists[i].irq_info.lock);
ret = uart_register_driver(&serial8250_reg);
if (ret)
next prev parent reply other threads:[~2008-07-31 8:27 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-29 21:14 [PATCH] x86: 64bit support more than 256 irq v2 Yinghai Lu
2008-07-29 22:16 ` Yinghai Lu
2008-07-29 23:22 ` Eric W. Biederman
2008-07-30 4:38 ` RFC [PATCH] x86: introduce nr_irqs for 64bit Yinghai Lu
2008-07-30 10:09 ` Ingo Molnar
2008-07-30 10:16 ` Yinghai Lu
2008-07-30 12:58 ` Mike Travis
2008-07-30 10:11 ` [PATCH] x86: introduce nr_irqs for 64bit v2 Yinghai Lu
2008-07-30 19:10 ` [PATCH 0/7] dyn_array support Yinghai Lu
2008-07-30 19:13 ` [PATCH 2/7] x86: introduce nr_irqs for 64bit v3 Yinghai Lu
2008-07-30 19:16 ` [PATCH 5/7] pci: make irq2_iommu to use dyn_array Yinghai Lu
2008-07-30 19:18 ` [PATCH 7/7] x86: make 64bit support dyn_array Yinghai Lu
2008-07-30 19:27 ` [PATCH 1/7] x86: 64bit support more than 256 irq v1 Yinghai Lu
2008-07-30 19:37 ` [PATCH 3/7] add dyn_array support Yinghai Lu
2008-07-30 19:40 ` [PATCH 6/7] irq: make irq_desc to use dyn_array Yinghai Lu
2008-07-30 19:40 ` [PATCH 4/7] random: make irq_timer_state " Yinghai Lu
2008-07-31 4:09 ` [PATCH 0/3] dyn_array support #2 Yinghai Lu
2008-07-31 4:10 ` [PATCH 1/3] serial: change irq_lists to use dyn_array Yinghai Lu
2008-07-31 5:58 ` Eric W. Biederman
2008-07-31 8:26 ` Yinghai Lu [this message]
2008-07-31 11:50 ` [PATCH] serial: change remove NR_IRQS in 8250.c Eric W. Biederman
2008-07-31 13:57 ` Alan Cox
2008-07-31 18:10 ` Eric W. Biederman
2008-07-31 23:15 ` Alan Cox
2008-08-01 3:20 ` Yinghai Lu
2008-07-31 4:11 ` [PATCH 2/3] add per_cpu_dyn_array support Yinghai Lu
2008-07-31 4:12 ` [PATCH 3/3] irq: make irqs in kernel stat use per_cpu_dyn_array Yinghai Lu
2008-07-31 10:14 ` [PATCH] x86 remove irq_vectors_limit.h Yinghai Lu
2008-07-31 16:32 ` [PATCH 0/3] dyn_array support #2 Mike Travis
2008-07-31 18:21 ` Yinghai Lu
2008-07-31 21:51 ` Peter Zijlstra
2008-07-31 22:07 ` Yinghai Lu
2008-07-31 22:25 ` Yinghai Lu
2008-08-01 3:52 ` Yinghai Lu
2008-07-31 22:14 ` Eric W. Biederman
2008-08-01 20:13 ` [PATCH 0/7] dyn_array support Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807310126.12572.yhlu.kernel@gmail.com \
--to=yhlu.kernel@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dhaval@linux.vnet.ibm.com \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=travis@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox