From: David Fries <david@fries.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Evgeniy Polyakov <johnpol@2ka.mipt.ru>, linux-kernel@vger.kernel.org
Subject: [PATCH 17/30] W1: w1_io.c reset comments and msleep
Date: Wed, 30 Jul 2008 21:49:47 -0500 [thread overview]
Message-ID: <20080731024947.GR12181@spacedout.fries.net> (raw)
In-Reply-To: <20080729161356.2de456fb.akpm@linux-foundation.org>
w1_reset_bus, added some comments about the timing and switched to
msleep for the later delay. I don't have the hardware to test the
sleep after reset change. The one wire doesn't have a timing
requirement between commands so it is fine. I do have the USB
hardware and it would be in big trouble with 10ms interrupt transfers
to find that the reset completed.
Signed-off-by: David Fries <david@fries.net>
Signed-off-by: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
---
drivers/w1/w1_io.c | 14 +++++++++++++-
1 files changed, 13 insertions(+), 1 deletions(-)
diff --git a/drivers/w1/w1_io.c b/drivers/w1/w1_io.c
index 97b338a..f4f82f1 100644
--- a/drivers/w1/w1_io.c
+++ b/drivers/w1/w1_io.c
@@ -293,12 +293,24 @@ int w1_reset_bus(struct w1_master *dev)
result = dev->bus_master->reset_bus(dev->bus_master->data) & 0x1;
else {
dev->bus_master->write_bit(dev->bus_master->data, 0);
+ /* minimum 480, max ? us
+ * be nice and sleep, except 18b20 spec lists 960us maximum,
+ * so until we can sleep with microsecond accuracy, spin.
+ * Feel free to come up with some other way to give up the
+ * cpu for such a short amount of time AND get it back in
+ * the maximum amount of time.
+ */
w1_delay(480);
dev->bus_master->write_bit(dev->bus_master->data, 1);
w1_delay(70);
result = dev->bus_master->read_bit(dev->bus_master->data) & 0x1;
- w1_delay(410);
+ /* minmum 70 (above) + 410 = 480 us
+ * There aren't any timing requirements between a reset and
+ * the following transactions. Sleeping is safe here.
+ */
+ /* w1_delay(410); min required time */
+ msleep(1);
}
return result;
--
1.4.4.4
next prev parent reply other threads:[~2008-07-31 2:53 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-29 2:04 [PATCH 0/30] W1: w1 core fixes, ds2490 updates, strong pullup David Fries
2008-07-29 2:10 ` [PATCH 1/30] W1: fix deadlocks and remove w1_control_thread David Fries
2008-07-29 2:12 ` [PATCH 2/30] W1: abort search early on on exit David Fries
2008-07-29 2:13 ` [PATCH 3/30] W1: don't delay search start David Fries
2008-07-29 2:14 ` [PATCH 4/30] W1: w1_process, block or sleep David Fries
2008-07-29 2:14 ` [PATCH 5/30] W1: feature, enable hardware strong pullup David Fries
2008-07-29 23:21 ` Andrew Morton
2008-07-29 2:15 ` [PATCH 6/30] W1: feature, w1_therm.c use strong pullup and documentation David Fries
2008-07-29 2:17 ` [PATCH 7/30] W1: be able to manually add and remove slaves David Fries
2008-07-29 2:18 ` [PATCH 8/30] W1: recode w1_slave_found logic David Fries
2008-07-29 2:19 ` [PATCH 9/30] W1: new module parameter search_count David Fries
2008-07-29 2:20 ` [PATCH 10/30] W1: Document add, remove, search_count, and pullup David Fries
2008-07-29 2:21 ` [PATCH 11/30] W1: w1_slave_read_id read bug, use device_attribute David Fries
2008-07-29 2:21 ` [PATCH 12/30] W1: w1_therm fix user buffer overflow and cat David Fries
2008-07-29 2:21 ` [PATCH 13/30] W1: w1_family, remove unused variable need_exit David Fries
2008-07-29 2:22 ` [PATCH 14/30] W1: w1_therm consistent mutex access code cleanup David Fries
2008-07-29 2:23 ` [PATCH 15/30] W1: w1_int.c use first available master number David Fries
2008-07-29 2:23 ` [PATCH 16/30] W1: w1.c s/printk/dev_dbg/ David Fries
2008-07-29 2:24 ` [PATCH 17/30] W1: w1_io.c reset comments and msleep David Fries
2008-07-29 2:24 ` [PATCH 18/30] W1: ds1wm.c msleep for reset David Fries
2008-07-29 2:25 ` [PATCH 19/30] W1: ds2490.c correct print message David Fries
2008-07-29 2:25 ` [PATCH 20/30] W1: ds2490.c add support for strong pullup David Fries
2008-07-29 2:25 ` [PATCH 21/30] W1: ds2490.c ds_write_bit, grouping error, disable readback David Fries
2008-07-29 2:25 ` [PATCH 22/30] W1: ds2490.c disable bit read and write David Fries
2008-07-29 2:26 ` [PATCH 23/30] W1: ds2490.c simplify and fix ds_touch_bit David Fries
2008-07-29 2:26 ` [PATCH 24/30] W1: ds2490.c ds_dump_status rework David Fries
2008-07-29 2:26 ` [PATCH 25/30] W1: ds2490.c ds_reset remove ds_wait_status David Fries
2008-07-29 2:27 ` [PATCH 26/30] W1: ds2490.c reset ds2490 in init David Fries
2008-07-29 2:28 ` [PATCH 27/30] W1: ds2490.c magic number work David Fries
2008-07-29 2:28 ` [PATCH 28/30] W1: ds2490.c ds_write_block remove extra ds_wait_status David Fries
2008-07-29 2:29 ` [PATCH 29/30] W1: Documentation/w1/masters/ds2490 update David Fries
2008-07-29 2:30 ` [PATCH 30/30] W1: ds2490.c optimize ds_set_pullup David Fries
2008-07-29 23:13 ` [PATCH 0/30] W1: w1 core fixes, ds2490 updates, strong pullup Andrew Morton
2008-07-31 2:37 ` David Fries
2008-07-31 3:03 ` Andrew Morton
2008-07-31 2:47 ` [PATCH 1/30] W1: fix deadlocks and remove w1_control_thread David Fries
2008-07-31 2:48 ` [PATCH 2/30] W1: abort search early on on exit David Fries
2008-07-31 2:48 ` [PATCH 3/30] W1: don't delay search start David Fries
2008-07-31 2:48 ` [PATCH 4/30] W1: w1_process, block or sleep David Fries
2008-07-31 2:48 ` [PATCH 5/30] W1: feature, enable hardware strong pullup David Fries
2008-07-31 2:48 ` [PATCH 6/30] W1: feature, w1_therm.c use strong pullup and documentation David Fries
2008-07-31 2:48 ` [PATCH 7/30] W1: be able to manually add and remove slaves David Fries
2008-07-31 2:48 ` [PATCH 8/30] W1: recode w1_slave_found logic David Fries
2008-07-31 2:48 ` [PATCH 9/30] W1: new module parameter search_count David Fries
2008-07-31 2:49 ` [PATCH 10/30] W1: Document add, remove, search_count, and pullup David Fries
2008-07-31 2:49 ` [PATCH 11/30] W1: w1_slave_read_id read bug, use device_attribute David Fries
2008-07-31 2:49 ` [PATCH 12/30] W1: w1_therm fix user buffer overflow and cat David Fries
2008-07-31 2:49 ` [PATCH 13/30] W1: w1_family, remove unused variable need_exit David Fries
2008-07-31 2:49 ` [PATCH 14/30] W1: w1_therm consistent mutex access code cleanup David Fries
2008-07-31 2:49 ` [PATCH 15/30] W1: w1_int.c use first available master number David Fries
2008-07-31 2:49 ` [PATCH 16/30] W1: w1.c s/printk/dev_dbg/ David Fries
2008-07-31 2:49 ` David Fries [this message]
2008-07-31 2:49 ` [PATCH 18/30] W1: ds1wm.c msleep for reset David Fries
2008-07-31 2:49 ` [PATCH 19/30] W1: ds2490.c correct print message David Fries
2008-07-31 2:49 ` [PATCH 20/30] W1: ds2490.c add support for strong pullup David Fries
2008-07-31 2:50 ` [PATCH 21/30] W1: ds2490.c ds_write_bit, grouping error, disable readback David Fries
2008-07-31 2:50 ` [PATCH 22/30] W1: ds2490.c disable bit read and write David Fries
2008-07-31 2:50 ` [PATCH 23/30] W1: ds2490.c simplify and fix ds_touch_bit David Fries
2008-07-31 2:50 ` [PATCH 24/30] W1: ds2490.c ds_dump_status rework David Fries
2008-07-31 2:50 ` [PATCH 25/30] W1: ds2490.c ds_reset remove ds_wait_status David Fries
2008-07-31 2:50 ` [PATCH 26/30] W1: ds2490.c reset ds2490 in init David Fries
2008-07-31 2:50 ` [PATCH 27/30] W1: ds2490.c magic number work David Fries
2008-07-31 2:50 ` [PATCH 28/30] W1: ds2490.c ds_write_block remove extra ds_wait_status David Fries
2008-07-31 2:50 ` [PATCH 29/30] W1: Documentation/w1/masters/ds2490 update David Fries
2008-07-31 2:50 ` [PATCH 30/30] W1: ds2490.c optimize ds_set_pullup David Fries
-- strict thread matches above, loose matches on Subject: below --
2008-07-11 13:51 w1 updates Evgeniy Polyakov
2008-07-11 13:51 ` [PATCH 17/30] W1: w1_io.c reset comments and msleep Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080731024947.GR12181@spacedout.fries.net \
--to=david@fries.net \
--cc=akpm@linux-foundation.org \
--cc=johnpol@2ka.mipt.ru \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox