From: Andi Kleen <andi@firstfloor.org>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Bert Wesarg <bert.wesarg@googlemail.com>,
Tejun Heo <htejun@gmail.com>, Andi Kleen <andi@firstfloor.org>
Subject: Re: [PULL] typesafe callbacks for kthread and stop_machine
Date: Thu, 31 Jul 2008 16:06:43 +0200 [thread overview]
Message-ID: <20080731140643.GO23938@one.firstfloor.org> (raw)
In-Reply-To: <200807311452.36025.rusty@rustcorp.com.au>
On Thu, Jul 31, 2008 at 02:52:35PM +1000, Rusty Russell wrote:
> Just the two places I look after. And this time the conglomerate patch is
> included below for more random commentry.
I must say I personally don't like the wrapper macros that you require
for each function that uses this. A wrapper macro has a large impact
on code readability because everyone following a call chain has
to do an additional grep/open file etc. step. I have my doubts not having casts
outweights that disadvantage.
I know that gcc has this funky transparent union extension that
glibc socket() uses to allow different address types without casts.
It has the advantage of not needing wrapper macros. Any chance of
using that instead? Or has that one been considered already and
discarded?
-Andi
next prev parent reply other threads:[~2008-07-31 14:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-31 4:52 [PULL] typesafe callbacks for kthread and stop_machine Rusty Russell
2008-07-31 14:06 ` Andi Kleen [this message]
2008-08-01 0:39 ` Rusty Russell
2008-08-01 14:28 ` Andi Kleen
2008-08-03 10:24 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080731140643.GO23938@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=bert.wesarg@googlemail.com \
--cc=htejun@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox