Re: linux-next: Tree for July 30

Andrew Morton
2008-07-31T20:13:45Z

On Thu, 31 Jul 2008 15:42:07 -0400
Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:

> - return bits_to_user(bits, len, _IOC_SIZE(cmd), p, compat_mode);
> +
> + if ((_IOC_NR(cmd) & EV_MAX) == EV_KEY && buf_len == 0x1ff) {
> + printk(KERN_WARNING
> + "evdev.c(EVIOCGBIT): Detected suspicious "
> + "buffer size 0x1ff, limiting output to 64 "
> + "bytes. Make sure you are not using "
> + "EVIOCGBIT(EV_KEY, KEY_MAX)\n");
> + buf_len = 64;
> + }

If that works then great. But I think the printk could be improved.
Please provide sufficient information so that users (not programmers)
can go off and fix things up without needing to email kernel developers.

One suitable approach would be

printk("see http://userweb.kernel.org/~dtor/read-this.txt")