From: Ingo Molnar <mingo@elte.hu>
To: Peter Zijlstra <peterz@infradead.org>
Cc: David Miller <davem@davemloft.net>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lockdep: change scheduler annotation
Date: Thu, 31 Jul 2008 18:34:56 +0200 [thread overview]
Message-ID: <20080731163456.GE26393@elte.hu> (raw)
In-Reply-To: <1217417217.8157.23.camel@twins>
* Peter Zijlstra <peterz@infradead.org> wrote:
> While thinking about David's patch it _finally_ dawned on me that
> there is no reason we have a lock class per cpu..
/me arghs too! :)
> Sorry for being dense :-/
>
> The below changes the annotation from a lock class per cpu, to a
> single nested lock, as the scheduler never holds more that 2 rq locks
> at a time anyway.
>
> If there was code requiring holding all rq locks this would not work
> and the original annotation would be the only option, but that not
> being the case, this is a much lighter one.
>
> Compiles and boots on a 2-way x86_64.
applied to tip/sched/urgent - thanks Peter!
Ingo
next prev parent reply other threads:[~2008-07-31 16:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-28 22:37 combinatorial explosion in lockdep David Miller
2008-07-28 22:50 ` Jeremy Fitzhardinge
2008-07-28 22:56 ` David Miller
2008-07-28 23:13 ` David Miller
2008-07-28 23:51 ` Ingo Molnar
2008-07-29 0:44 ` David Miller
2008-07-30 4:45 ` David Miller
2008-07-30 6:56 ` David Miller
2008-07-30 7:21 ` Peter Zijlstra
2008-07-30 7:19 ` Peter Zijlstra
2008-07-30 11:15 ` Peter Zijlstra
2008-07-31 16:50 ` [stable] " Greg KH
2008-07-30 11:26 ` [PATCH] lockdep: change scheduler annotation Peter Zijlstra
2008-07-30 11:34 ` David Miller
2008-07-31 16:34 ` Ingo Molnar [this message]
2008-07-31 16:39 ` combinatorial explosion in lockdep Ingo Molnar
2008-08-01 9:22 ` Ingo Molnar
2008-08-01 9:32 ` David Miller
2008-08-01 11:57 ` Hugh Dickins
2008-08-03 8:14 ` David Miller
2008-08-04 12:21 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080731163456.GE26393@elte.hu \
--to=mingo@elte.hu \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox