Re: [patch v3] splice: fix race with page invalidation

Miklos Szeredi
2008-07-31T18:13:42Z

On Thu, 31 Jul 2008, Linus Torvalds wrote:
> On Thu, 31 Jul 2008, Nick Piggin wrote:
> >
> > It seems like the right way to fix this would be to allow the splicing
> > process to be notified of a short read, in which case it could try to
> > refill the pipe with the unread bytes...
>
> Hmm. That should certainly work with the splice model. The users of the
> data wouldn't eat (or ignore) the invalid data, they'd just say "invalid
> data", and stop. And it would be up to the other side to handle it (it
> can see the state of the pipe, we can make it both wake up POLL_ERR _and_
> return an error if somebody tries to write to a "blocked" pipe).
>
> So yes, that's very possible, but it obviously requires splice() users to
> be able to handle more cases. I'm not sure it's realistic to expect users
> to be that advanced.

Worse, it's not guaranteed to make any progress. E.g. on NFS server
with data being continually updated, cache on the client will
basically always be invalid, so the above scheme might just repeat the
splices forever without success.

Miklos