Re: [patch v3] splice: fix race with page invalidation

Miklos Szeredi
2008-07-30T17:30:30Z

On Wed, 30 Jul 2008, Linus Torvalds wrote:
> On Wed, 30 Jul 2008, Miklos Szeredi wrote:
> >
> > There are no real disadvantages: splice() from a file was
> > originally meant to be asynchronous, but in reality it only did
> > that for non-readahead pages, which happen rarely.
>
> I still don't like this. I still don't see the point, and I still
> think there is something fundamentally wrong elsewhere.

We discussed the possible solutions with Nick, and came to the
conclusion, that short term (i.e. 2.6.27) this is probably the best
solution.

Long term sure, I have no problem with implementing async splice.

In fact, I may even have personal interest in looking at splice,
because people are asking for a zero-copy interface for fuse.

But that is definitely not 2.6.27, so I think you should reconsider
taking this patch, which is obviously correct due to its simplicity,
and won't cause any performance regressions either.

Thanks,
Miklos