Re: [patch v3] splice: fix race with page invalidation

Miklos Szeredi
2008-07-30T20:06:59Z

On Wed, 30 Jul 2008, Jens Axboe wrote:
> On Wed, Jul 30 2008, Miklos Szeredi wrote:
> > > On Wed, 30 Jul 2008, Jens Axboe wrote:
> > > > You snipped the part where Linus objected to dismissing the async
> > > > nature, I fully agree with that part.
> >
> > And also note in what Nick said in the referenced mail: it would be
> > nice if someone actually _cared_ about the async nature. The fact
> > that it has been broken from the start, and nobody noticed is a strong
> > hint that currently there isn't anybody who does.
>
> That's largely due to the (still) lack of direct splice users. It's a
> clear part of the design and benefit of using splice. I very much care
> about this, and as soon as there are available cycles for this, I'll get
> it into better shape in this respect. Taking a step backwards is not the
> right way forward, imho.

So what is? The only way forward is to put those cycles into it,
which nobody seems to have available.

Take this patch as a bugfix. It's not in any way showing the way
forward: as soon as you have the time, you can revert it and start
from the current state.

Hmm?

Miklos