Re: [patch v3] splice: fix race with page invalidation

Miklos Szeredi
2008-07-30T21:16:46Z

> On Wed, 30 Jul 2008, Miklos Szeredi wrote:
> >
> > It _is_ a bug fix.
>
> No it's not.
>
> It's still papering over a totally unrelated bug. It's not a "fix", it's a
> "paper-over". It doesn't matter if _behaviour_ changes.
>
> Can you really not see the difference?
>
> Afaik, everybody pretty much agreed what the real fix should be (don't
> mark the page not up-to-date, just remove it from the radix tree)

Huh? I did exactly that, and that patch got NAK'ed by you and Nick:

http://lkml.org/lkml/2008/6/25/230
http://lkml.org/lkml/2008/7/7/21

Confused.

> I'm not seeing why you continue to push the patch that ALREADY GOT
> NAK'ed.

And later ACK'ed by Nick.

There's everything here but agreement about a solution :)

Miklos