From: Peter Oruba <peter.oruba@amd.com>
To: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
Tigran Aivazian <tigran@aivazian.fsnet.co.uk>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
LKML <linux-kernel@vger.kernel.org>,
Peter Oruba <peter.oruba@amd.com>
Subject: [patch 1/2] [PATCH 1/2] x86: Microcode patch loader style corrections
Date: Fri, 1 Aug 2008 12:46:45 +0200 [thread overview]
Message-ID: <20080801104754.303635665@amd.com> (raw)
In-Reply-To: 20080801104644.788786464@amd.com
[-- Attachment #1: 0001-x86-Microcode-patch-loader-style-corrections.patch --]
[-- Type: text/plain, Size: 3066 bytes --]
Style corrections to main microcode module.
Signed-off-by: Peter Oruba <peter.oruba@amd.com>
---
arch/x86/kernel/microcode.c | 24 +++++++++++++-----------
1 files changed, 13 insertions(+), 11 deletions(-)
diff --git a/arch/x86/kernel/microcode.c b/arch/x86/kernel/microcode.c
index 28dba1a..39961bb 100644
--- a/arch/x86/kernel/microcode.c
+++ b/arch/x86/kernel/microcode.c
@@ -55,8 +55,8 @@
* in a single CPU package.
* 1.10 28 Feb 2002 Asit K Mallick <asit.k.mallick@intel.com> and
* Tigran Aivazian <tigran@veritas.com>,
- * Serialize updates as required on HT processors due to speculative
- * nature of implementation.
+ * Serialize updates as required on HT processors due to
+ * speculative nature of implementation.
* 1.11 22 Mar 2002 Tigran Aivazian <tigran@veritas.com>
* Fix the panic when writing zero-length microcode chunk.
* 1.12 29 Sep 2003 Nitin Kamble <nitin.a.kamble@intel.com>,
@@ -71,7 +71,7 @@
* Thanks to Stuart Swales for pointing out this bug.
*/
-//#define DEBUG /* pr_debug */
+/*#define DEBUG pr_debug */
#include <linux/capability.h>
#include <linux/kernel.h>
#include <linux/init.h>
@@ -116,7 +116,7 @@ EXPORT_SYMBOL_GPL(user_buffer);
unsigned int user_buffer_size; /* it's size */
EXPORT_SYMBOL_GPL(user_buffer_size);
-static int do_microcode_update (void)
+static int do_microcode_update(void)
{
long cursor = 0;
int error = 0;
@@ -158,18 +158,20 @@ out:
return error;
}
-static int microcode_open (struct inode *unused1, struct file *unused2)
+static int microcode_open(struct inode *unused1, struct file *unused2)
{
cycle_kernel_lock();
return capable(CAP_SYS_RAWIO) ? 0 : -EPERM;
}
-static ssize_t microcode_write (struct file *file, const char __user *buf, size_t len, loff_t *ppos)
+static ssize_t microcode_write(struct file *file, const char __user *buf,
+ size_t len, loff_t *ppos)
{
ssize_t ret;
if ((len >> PAGE_SHIFT) > num_physpages) {
- printk(KERN_ERR "microcode: too much data (max %ld pages)\n", num_physpages);
+ printk(KERN_ERR "microcode: too much data (max %ld pages)\n",
+ num_physpages);
return -EINVAL;
}
@@ -201,7 +203,7 @@ static struct miscdevice microcode_dev = {
.fops = µcode_fops,
};
-static int __init microcode_dev_init (void)
+static int __init microcode_dev_init(void)
{
int error;
@@ -216,7 +218,7 @@ static int __init microcode_dev_init (void)
return 0;
}
-static void microcode_dev_exit (void)
+static void microcode_dev_exit(void)
{
misc_deregister(µcode_dev);
}
@@ -224,7 +226,7 @@ static void microcode_dev_exit (void)
MODULE_ALIAS_MISCDEV(MICROCODE_MINOR);
#else
#define microcode_dev_init() 0
-#define microcode_dev_exit() do { } while(0)
+#define microcode_dev_exit() do { } while (0)
#endif
/* fake device for request_firmware */
@@ -451,7 +453,7 @@ int microcode_init(void *opaque, struct module *module)
}
EXPORT_SYMBOL_GPL(microcode_init);
-void __exit microcode_exit (void)
+void __exit microcode_exit(void)
{
microcode_dev_exit();
--
1.5.4.5
next prev parent reply other threads:[~2008-08-01 10:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-01 10:46 [patch 0/2] x86: microcode patch loader cleanup and fix Peter Oruba
2008-08-01 10:46 ` Peter Oruba [this message]
2008-08-14 2:03 ` [patch 1/2] [PATCH 1/2] x86: Microcode patch loader style corrections Andrew Morton
2008-08-01 10:46 ` [patch 2/2] [PATCH 2/2] x86: Fixed NULL function pointer dereference in AMD microcode patch loader Peter Oruba
2008-08-14 2:05 ` Andrew Morton
2008-08-14 11:55 ` Peter Oruba
2008-08-15 15:19 ` [patch 0/2] x86: microcode patch loader cleanup and fix Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080801104754.303635665@amd.com \
--to=peter.oruba@amd.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=tigran@aivazian.fsnet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox