From: Josef Bacik <jbacik@redhat.com>
To: Ric Wheeler <rwheeler@redhat.com>
Cc: Josef Bacik <jbacik@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
linux-fsdevel@vger.kernel.org,
Chris Mason <chris.mason@oracle.com>,
linux-kernel@vger.kernel.org
Subject: Re: high resolution timers, scheduling & sleep granularity
Date: Fri, 1 Aug 2008 09:55:08 -0400 [thread overview]
Message-ID: <20080801135508.GC14001@unused.rdu.redhat.com> (raw)
In-Reply-To: <4893164D.1@redhat.com>
On Fri, Aug 01, 2008 at 09:57:33AM -0400, Ric Wheeler wrote:
> Josef Bacik wrote:
>> On Fri, Aug 01, 2008 at 08:05:37AM -0400, Ric Wheeler wrote:
>>
>>> Hi Thomas & Ingo,
>>>
>>> Josef has been working on some patches to try and get ext3/4 to
>>> dynamically detect the latency of a storage device and use that base
>>> latency to tune the amount of time we sleep waiting for others to join in
>>> a transaction. The logic in question lives in jbd/transaction.c
>>> (transaction_stop).
>>>
>>> The code was originally developed to try and allow multiple threads to
>>> join in a big, slow transaction. For example, transacations that write to
>>> a slow ATA or S-ATA drive take in the neighborhood of 10 to 20 ms.
>>>
>>> Faster devices, for example a disk array, can complete the transaction
>>> in 1.3 ms. Even higher speed SSD devices boast of a latency of 0.1ms, not
>>> to mention RAM disks ;-)
>>>
>>> The current logic makes us wait way too long, especially with a 250HZ
>>> kernel since we sleep many times longer than it takes to complete the IO
>>> ;-)
>>>
>>> Do either of you have any thoughts on how to get a better, fine grained
>>> sleep capability that we could use that would allow us to sleep in
>>> sub-jiffie chunks?
>>>
>>>
>>
>> Hello,
>>
>> This is the most recent iteration of my patch using hrtimers. It works really
>> well for ramdisks, so anything with low latency writes is going to be really
>> fast, but I'm still trying to come up with a smart way to sleep long enough to
>> not hurt SATA performance. As it stands now I'm getting a 5% decrease in speed
>> on SATA. So I think I've got the sleep as little as possible part down right,
>> just can't quite get it to sleep long enough if the disk is slow. Thanks,
>>
>> Josef
>>
>
> I think that this (or similar) kind of precision_sleep() should be
> generically useful.
>
> One question on the code, would it be better to measure the average
> transaction time in the same units as your precision sleep uses - aren't
> jiffies are still too coarse?
>
Oh well crap I guess thats why I'm not sleeping long enough, i'm only sleeping
jiffies number of nanoseconds, and jiffies is much higher than nanoseconds...
/me writes jiffies * HZ = seconds backwards on his forehead
Josef
next prev parent reply other threads:[~2008-08-01 14:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-01 12:05 high resolution timers, scheduling & sleep granularity Ric Wheeler
2008-08-01 13:25 ` Josef Bacik
2008-08-01 13:57 ` Ric Wheeler
2008-08-01 13:55 ` Josef Bacik [this message]
2008-08-01 14:50 ` Peter Zijlstra
2008-08-01 14:34 ` Josef Bacik
2008-08-01 15:03 ` Ric Wheeler
2008-08-01 18:16 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080801135508.GC14001@unused.rdu.redhat.com \
--to=jbacik@redhat.com \
--cc=chris.mason@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rwheeler@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox