Re: [regression] nf_iterate(), BUG: unable to handle kernel NULL pointer dereference

Herbert Xu
2008-07-25T01:41:11Z

On Thu, Jul 24, 2008 at 12:47:19PM -0500, Matt Mackall wrote:
>
> Let's try this again: did you know that ksize could fail depending on
> kernel configuration? Most of us would answer no. That suggests the API
> is bad. This ranks 12 on Rusty's spectrum of user-friendly APIs:

I think you misunderstood my argument. I never suggested changing
the existing ksize interface to return an error onto unsuspecting
users. I suggested creating a new interface that is explicitly
designed to return an error if the underlying implementation
is unable to support this.

Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt