[PATCH 2/2] cpuset: use seq_cpumask(), seq_nodemask()

[PATCH 2/2] cpuset: use seq_cpumask(), seq_nodemask()

[Alexey Dobriyan]

Folks might want to boot with NR_CPUS=4096 and see what happens,
m->count games don't look promising. :-)

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---

 kernel/cpuset.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

--- a/kernel/cpuset.c
+++ b/kernel/cpuset.c
@@ -2392,16 +2392,14 @@ const struct file_operations proc_cpuset_operations = {
 void cpuset_task_status_allowed(struct seq_file *m, struct task_struct *task)
 {
 	seq_printf(m, "Cpus_allowed:\t");
-	m->count += cpumask_scnprintf(m->buf + m->count, m->size - m->count,
-					task->cpus_allowed);
+	seq_cpumask(m, &task->cpus_allowed);
 	seq_printf(m, "\n");
 	seq_printf(m, "Cpus_allowed_list:\t");
 	m->count += cpulist_scnprintf(m->buf + m->count, m->size - m->count,
 					task->cpus_allowed);
 	seq_printf(m, "\n");
 	seq_printf(m, "Mems_allowed:\t");
-	m->count += nodemask_scnprintf(m->buf + m->count, m->size - m->count,
-					task->mems_allowed);
+	seq_nodemask(m, &task->mems_allowed);
 	seq_printf(m, "\n");
 	seq_printf(m, "Mems_allowed_list:\t");
 	m->count += nodelist_scnprintf(m->buf + m->count, m->size - m->count,
-- 
1.5.3.7

Re: [PATCH 2/2] cpuset: use seq_cpumask(), seq_nodemask()

[Paul Jackson]

Alexey wrote:
> Folks might want to boot with NR_CPUS=4096 and see what happens,
> m->count games don't look promising. :-)

That comment is rather heavily dependent on the context of both:
 1) the previous patch comment, and
 2) booting and seeing.

Could you rewrite it, so that it doesn't depend on such context,
and can be read and understood, by itself?

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@sgi.com> 1.940.382.4214

Re: [PATCH 2/2] cpuset: use seq_cpumask(), seq_nodemask()

[Alexey Dobriyan]

On Sat, Aug 02, 2008 at 09:05:42AM -0500, Paul Jackson wrote:
> Alexey wrote:
> > Folks might want to boot with NR_CPUS=4096 and see what happens,
> > m->count games don't look promising. :-)
> 
> That comment is rather heavily dependent on the context of both:
>  1) the previous patch comment, and
>  2) booting and seeing.
> 
> Could you rewrite it, so that it doesn't depend on such context,
> and can be read and understood, by itself?

That's just a reminder to cpuset people whether /proc/*/status broken or
not. Can be safely deleted. :-)

Re: [PATCH 2/2] cpuset: use seq_cpumask(), seq_nodemask()

[Paul Jackson]

Alexey wrote:
> That's just a reminder to cpuset people whether /proc/*/status broken or
> not. Can be safely deleted. :-)

What can be safely deleted - the patch, or the comment of the patch?

I'm confused.

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@sgi.com> 1.940.382.4214

Re: [PATCH 2/2] cpuset: use seq_cpumask(), seq_nodemask()

[Andrew Morton]

On Sat, 2 Aug 2008 18:28:38 +0400 Alexey Dobriyan <adobriyan@gmail.com> wrote:

> On Sat, Aug 02, 2008 at 09:05:42AM -0500, Paul Jackson wrote:
> > Alexey wrote:
> > > Folks might want to boot with NR_CPUS=4096 and see what happens,
> > > m->count games don't look promising. :-)
> > 
> > That comment is rather heavily dependent on the context of both:
> >  1) the previous patch comment, and
> >  2) booting and seeing.
> > 
> > Could you rewrite it, so that it doesn't depend on such context,
> > and can be read and understood, by itself?

I agree with Paul.  That changelog was useless, sorry.

> That's just a reminder to cpuset people whether /proc/*/status broken or
> not. Can be safely deleted. :-)

Deleting the changelog won't make it clearer (unlike some changelogs
which I've seen ;))

Please send a usable changleog for this patch, thanks.