From: Andrew Morton <akpm@linux-foundation.org>
To: Simon Horman <horms@verge.net.au>
Cc: kexec@lists.infradead.org, linux-ia64@vger.kernel.org,
linux-kernel@vger.kernel.org, Vivek Goyal <vgoyal@redhat.com>,
Tony Luck <tony.luck@intel.com>
Subject: Re: kdump, ia64: always reserve elfcore header memory in crash kernel
Date: Tue, 5 Aug 2008 02:54:42 -0700 [thread overview]
Message-ID: <20080805025442.d4626d40.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080805094825.GA9712@verge.net.au>
On Tue, 5 Aug 2008 19:48:27 +1000 Simon Horman <horms@verge.net.au> wrote:
> elfcore header memory needs to be reserved in a crash kernel.
> This means that the relevant code should be protected
> by CONFIG_CRASH_DUMP rather than CONFIG_PROC_VMCORE.
>
> Signed-off-by: Simon Horman <horms@verge.net.au>
>
> ---
> Andrew, this patch fixes bug in the (unlikely) case where
> an ia64 crashdump kernel does not have CONFIG_PROC_FS set.
> I think it is worth including in 2.6.27. But breakage cases are
> likely to be minimal to non-existent, so I am comfortable
> with post 2.6.27 too.
>
> This patch should be appended to the series,
> "is_kdump_kernel() cleanup and related patches".
hm, that means that we would need to apply a moderate-size seven patch
series to fix one little bug.
I think that if we want to fix this in 2.6.27 then the basic single
patch would be preferable. Or we leave it until 2.6.28/
next prev parent reply other threads:[~2008-08-05 9:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-05 9:48 kdump, ia64: always reserve elfcore header memory in crash kernel Simon Horman
2008-08-05 9:54 ` Andrew Morton [this message]
2008-08-05 10:14 ` Simon Horman
2008-08-05 12:56 ` Vivek Goyal
2008-08-05 23:47 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080805025442.d4626d40.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox