Re: pull request: wireless-2.6 2008-08-04

Marcel Holtmann
2008-08-04T22:33:42Z

Hi John,

> > > > > Luis R. Rodriguez (4):
> > > > > list.h: Add list_splice_tail() and list_splice_tail_init()
> > > > > list.h: add list_cut_position()
> > > >
> > > > have these two changes got reviewed on LKML? I don't see any ACKs for it
> > > > in the commit message.
> > >
> > > Hmmm...no. I thought the original patches had been copied to
> > > linux-kernel, but it looks like that is not the case.
> > >
> > > The original patches are archived here:
> > >
> > > http://marc.info/?l=linux-wireless&m=121783421908441&w=2
> > >
> > > http://marc.info/?l=linux-wireless&m=121783422008445&w=2
> > >
> > > What problems do you see with them?
> >
> > I don't see a problem with these patches, but they should at least be
> > reviewed on LKML once. Changes to core kernel infrastructure should not
> > be merged silently via subsystem trees without any kind of ACKs.
>
> Yes, fine. That wasn't my intent. :-) The patches were originally
> posted about two weeks ago, too bad that didn't actually go to
> linux-kernel. :-(

just post them to LKML (or let Luis do it) so they get reviewed. I
really don't see an issue with them, but that is only me.

Regards

Marcel