Re: [PATCH] Intel Management Engine Interface

[Pavel Machek <pavel@suse.cz>]

Hi!

> Fixed more issues raised on lkml after previous submission.
> 
> 
> The Intel Management Engine Interface (aka HECI: Host Embedded
> Controller Interface ) enables communication between the host OS and
> the Management Engine firmware. MEI is bi-directional, and either the
> host or Intel AMT firmware can initiate transactions.
> 
> The core hardware architecture of Intel Active Management Technology
> (Intel AMT) is resident in firmware. The micro-controller within the
> chipset's graphics and memory controller (GMCH) hub houses the
> Management Engine (ME) firmware, which implements various services
> on behalf of management applications.
> 
> Some of the ME subsystems that can be access via MEI driver:
> 
> - Intel(R) Quiet System Technology (QST) is implemented as a firmware
> subsystem  that  runs in the ME.  Programs that wish to expose the
> health monitoring and fan speed control capabilities of Intel(R) QST
> will need to use the MEI driver to communicate with the ME sub-system.
> - ASF is the "Alert Standard Format" which is an DMTF manageability
> standard. It is implemented in the PC's hardware and firmware, and is
> managed from a remote console.

Cool, so this should hook into sensors subsystem, right?

Also it uses __x32-style types when x32 would be enough.

> +	heci_check_asf_mode(dev);
> +	/*heci initialization wd */

That is not exactly helpful comment... Decrypt? Space after /*?


> +	DBG("call wait_event_interruptible_timeout for response message.\n");
> +	/* wait for response */

Home-brewn DBG is un-nice.

> +static int host_enum_clients_message(struct iamt_heci_device *dev)
> +{
> +	long timeout = 5;	/*5 second */
> +	struct heci_msg_hdr *heci_hdr;
> +	struct hbm_host_enum_request *host_enum_req;
> +	int err = 0;
> +	__u8 i, j;

int is probably better here.


-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html