From: Robert Richter <robert.richter@amd.com>
To: "Gustavo F. Padovan" <gustavo@las.ic.unicamp.br>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu
Subject: Re: [PATCH 02/24] x86: kernel/apm_32.c cleanup
Date: Thu, 7 Aug 2008 11:47:58 +0200 [thread overview]
Message-ID: <20080807094754.GA32164@erda.amd.com> (raw)
In-Reply-To: <1217279371-4410-3-git-send-email-gustavo@las.ic.unicamp.br>
On 28.07.08 18:09:09, Gustavo F. Padovan wrote:
> Remove additional whitespaces and tabs.
>
> Signed-off-by: Gustavo F. Padovan <gustavo@las.ic.unicamp.br>
> ---
> arch/x86/kernel/apm_32.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/x86/kernel/apm_32.c b/arch/x86/kernel/apm_32.c
> index 9ee24e6..b0c049c 100644
> --- a/arch/x86/kernel/apm_32.c
> +++ b/arch/x86/kernel/apm_32.c
> @@ -435,7 +435,7 @@ static const char * const apm_event_name[] = {
>
> typedef struct lookup_t {
> int key;
> - char *msg;
> + char *msg;
Shouldn't this be a tab?
> } lookup_t;
>
> /*
> @@ -1679,8 +1679,8 @@ static int apm(void *unused)
> unsigned short cx;
> unsigned short dx;
> int error;
> - char *power_stat;
> - char *bat_stat;
> + char *power_stat;
> + char *bat_stat;
Why not using same indention as for error?
-Robert
>
> #ifdef CONFIG_SMP
> /* 2002/08/01 - WT
> --
> 1.5.4.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
--
Advanced Micro Devices, Inc.
Operating System Research Center
email: robert.richter@amd.com
next prev parent reply other threads:[~2008-08-07 12:21 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-28 21:09 [PATCH 0/24] x86: arch/x86/kernel/ cleanups Gustavo F. Padovan
2008-07-28 21:09 ` [PATCH 01/24] x86: kernel/alternative.c cleanup Gustavo F. Padovan
2008-07-28 21:09 ` [PATCH 02/24] x86: kernel/apm_32.c cleanup Gustavo F. Padovan
2008-07-28 21:09 ` [PATCH 03/24] x86: kernel/asm-offsets_64.c cleanup Gustavo F. Padovan
2008-07-28 21:09 ` [PATCH 04/24] x86: kernel/efi.c cleanup Gustavo F. Padovan
2008-07-28 21:09 ` [PATCH 05/24] x86: kernel/cpuid.c cleanup Gustavo F. Padovan
2008-07-28 21:09 ` [PATCH 06/24] x86: kernel/early-quirks.c cleanup Gustavo F. Padovan
2008-07-28 21:09 ` [PATCH 07/24] x86: kernel/io_apic_32.c cleanup Gustavo F. Padovan
2008-07-28 21:09 ` [PATCH 08/24] x86: kernel/io_apic_64.c cleanup Gustavo F. Padovan
2008-07-28 21:09 ` [PATCH 09/24] x86: kernel/irq_64.c cleanup Gustavo F. Padovan
2008-07-28 21:09 ` [PATCH 10/24] x86: kernel/irqinit_32.c cleanup Gustavo F. Padovan
2008-07-28 21:09 ` [PATCH 11/24] x86: kernel/kprobes.c cleanup Gustavo F. Padovan
2008-07-28 21:09 ` [PATCH 12/24] x86: kernel/microcode.c cleanup Gustavo F. Padovan
2008-07-28 21:09 ` [PATCH 13/24] x86: kernel/module_64.c cleanup Gustavo F. Padovan
2008-07-28 21:09 ` [PATCH 14/24] x86: kernel/pci-calgary_64.c cleanup Gustavo F. Padovan
2008-07-28 21:09 ` [PATCH 15/24] x86: kernel/probe_roms_32.c cleanup Gustavo F. Padovan
2008-07-28 21:09 ` [PATCH 16/24] x86: kernel/process_32.c cleanup Gustavo F. Padovan
2008-07-28 21:09 ` [PATCH 17/24] x86: kernel/process_64.c cleanup Gustavo F. Padovan
2008-07-28 21:09 ` [PATCH 18/24] x86: kernel/signal_64.c cleanup Gustavo F. Padovan
2008-07-28 21:09 ` [PATCH 19/24] x86: kernel/traps_64.c cleanup Gustavo F. Padovan
2008-07-28 21:09 ` [PATCH 20/24] x86: kernel/tsc.c cleanup Gustavo F. Padovan
2008-07-28 21:09 ` [PATCH 21/24] x86: kernel/visws_quirks.c cleanup Gustavo F. Padovan
2008-07-28 21:09 ` [PATCH 22/24] x86: kernel/vmi_32.c cleanup Gustavo F. Padovan
2008-07-28 21:09 ` [PATCH 23/24] x86: kernel/vmiclock_32.c cleanup Gustavo F. Padovan
2008-07-28 21:09 ` [PATCH 24/24] x86: kernel/sys_x86_64.c cleanup Gustavo F. Padovan
2008-07-29 1:47 ` [PATCH 11/24] x86: kernel/kprobes.c cleanup Masami Hiramatsu
2008-08-07 9:47 ` Robert Richter [this message]
2008-07-28 21:17 ` [PATCH 0/24] x86: arch/x86/kernel/ cleanups Jeremy Fitzhardinge
2008-07-28 21:20 ` Ingo Molnar
2008-07-28 21:37 ` Gustavo F. Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080807094754.GA32164@erda.amd.com \
--to=robert.richter@amd.com \
--cc=gustavo@las.ic.unicamp.br \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox