* [patch][reiser4] compile warning cleanups
@ 2008-08-01 13:33 Ryan Hope
2008-08-07 18:45 ` Ryan Hope
0 siblings, 1 reply; 3+ messages in thread
From: Ryan Hope @ 2008-08-01 13:33 UTC (permalink / raw)
To: LKML, Andrew Morton
The following patch cleans up some reiser4 compile warnings:
From: Ryan Hope <rmh3093@gmail.com>
Date: Fri, 1 Aug 2008 13:25:28 +0000 (-0400)
Subject: cleanup reiser4 warnings
X-Git-Url: http://zen-sources.org/cgi-bin/gitweb.cgi?p=kernel.git;a=commitdiff_plain;h=675342fe83269780f2699f47972d0059e13db0cc
cleanup reiser4 warnings
---
diff --git a/fs/reiser4/plugin/file/cryptcompress.c
b/fs/reiser4/plugin/file/cryptcompress.c
index 2e64374..7d3061d 100644
--- a/fs/reiser4/plugin/file/cryptcompress.c
+++ b/fs/reiser4/plugin/file/cryptcompress.c
@@ -821,7 +821,7 @@ static int need_cut_or_align(struct inode * inode,
static void align_or_cut_overhead(struct inode * inode,
struct cluster_handle * ch, rw_op rw)
{
- int oh;
+ unsigned int oh;
cipher_plugin * cplug = inode_cipher_plugin(inode);
assert("edward-1402", need_cipher(inode));
diff --git a/fs/reiser4/plugin/inode_ops.c b/fs/reiser4/plugin/inode_ops.c
index 6ac4d13..945a740 100644
--- a/fs/reiser4/plugin/inode_ops.c
+++ b/fs/reiser4/plugin/inode_ops.c
@@ -418,8 +418,7 @@ void *reiser4_follow_link_common(struct dentry
*dentry, struct nameidata *nd)
*
* Uses generic function to check for rwx permissions.
*/
-int reiser4_permission_common(struct inode *inode, int mask,
- struct nameidata *nameidata)
+int reiser4_permission_common(struct inode *inode, int mask)
{
return generic_permission(inode, mask, NULL);
}
diff --git a/fs/reiser4/plugin/object.h b/fs/reiser4/plugin/object.h
index 63abb07..88a53a5 100644
--- a/fs/reiser4/plugin/object.h
+++ b/fs/reiser4/plugin/object.h
@@ -25,8 +25,7 @@ int reiser4_mknod_common(struct inode *parent,
struct dentry *dentry,
int reiser4_rename_common(struct inode *old_dir, struct dentry *old_name,
struct inode *new_dir, struct dentry *new_name);
void *reiser4_follow_link_common(struct dentry *, struct nameidata *data);
-int reiser4_permission_common(struct inode *, int mask,
- struct nameidata *nameidata);
+int reiser4_permission_common(struct inode *, int mask);
int reiser4_setattr_common(struct dentry *, struct iattr *);
int reiser4_getattr_common(struct vfsmount *mnt, struct dentry *,
struct kstat *);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [patch][reiser4] compile warning cleanups
2008-08-01 13:33 [patch][reiser4] compile warning cleanups Ryan Hope
@ 2008-08-07 18:45 ` Ryan Hope
2008-08-07 19:31 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Ryan Hope @ 2008-08-07 18:45 UTC (permalink / raw)
To: LKML, Andrew Morton
Hopefully this is not wordwrapped this time...
From: Ryan Hope <rmh3093@gmail.com>
Date: Fri, 1 Aug 2008 13:25:28 +0000 (-0400)
Subject: cleanup reiser4 warnings
X-Git-Url:
http://zen-sources.org/cgi-bin/gitweb.cgi?p=kernel.git;a=commitdiff_plain;h=675342fe83269780f2699f47972d0059e13db0cc
cleanup reiser4 warnings
---
diff --git a/fs/reiser4/plugin/file/cryptcompress.c
b/fs/reiser4/plugin/file/cryptcompress.c
index 2e64374..7d3061d 100644
--- a/fs/reiser4/plugin/file/cryptcompress.c
+++ b/fs/reiser4/plugin/file/cryptcompress.c
@@ -821,7 +821,7 @@ static int need_cut_or_align(struct inode * inode,
static void align_or_cut_overhead(struct inode * inode,
struct cluster_handle * ch, rw_op rw)
{
- int oh;
+ unsigned int oh;
cipher_plugin * cplug = inode_cipher_plugin(inode);
assert("edward-1402", need_cipher(inode));
diff --git a/fs/reiser4/plugin/inode_ops.c b/fs/reiser4/plugin/inode_ops.c
index 6ac4d13..945a740 100644
--- a/fs/reiser4/plugin/inode_ops.c
+++ b/fs/reiser4/plugin/inode_ops.c
@@ -418,8 +418,7 @@ void *reiser4_follow_link_common(struct dentry
*dentry, struct nameidata *nd)
*
* Uses generic function to check for rwx permissions.
*/
-int reiser4_permission_common(struct inode *inode, int mask,
- struct nameidata *nameidata)
+int reiser4_permission_common(struct inode *inode, int mask)
{
return generic_permission(inode, mask, NULL);
}
diff --git a/fs/reiser4/plugin/object.h b/fs/reiser4/plugin/object.h
index 63abb07..88a53a5 100644
--- a/fs/reiser4/plugin/object.h
+++ b/fs/reiser4/plugin/object.h
@@ -25,8 +25,7 @@ int reiser4_mknod_common(struct inode *parent, struct
dentry *dentry,
int reiser4_rename_common(struct inode *old_dir, struct dentry *old_name,
struct inode *new_dir, struct dentry *new_name);
void *reiser4_follow_link_common(struct dentry *, struct nameidata *data);
-int reiser4_permission_common(struct inode *, int mask,
- struct nameidata *nameidata);
+int reiser4_permission_common(struct inode *, int mask);
int reiser4_setattr_common(struct dentry *, struct iattr *);
int reiser4_getattr_common(struct vfsmount *mnt, struct dentry *,
struct kstat *);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [patch][reiser4] compile warning cleanups
2008-08-07 18:45 ` Ryan Hope
@ 2008-08-07 19:31 ` Andrew Morton
0 siblings, 0 replies; 3+ messages in thread
From: Andrew Morton @ 2008-08-07 19:31 UTC (permalink / raw)
To: Ryan Hope; +Cc: linux-kernel
On Thu, 07 Aug 2008 14:45:48 -0400
Ryan Hope <rmh3093@gmail.com> wrote:
> Hopefully this is not wordwrapped this time...
It is.
> From: Ryan Hope <rmh3093@gmail.com>
> Date: Fri, 1 Aug 2008 13:25:28 +0000 (-0400)
> Subject: cleanup reiser4 warnings
> X-Git-Url:
> http://zen-sources.org/cgi-bin/gitweb.cgi?p=kernel.git;a=commitdiff_plain;h=675342fe83269780f2699f47972d0059e13db0cc
>
> cleanup reiser4 warnings
> ---
>
> diff --git a/fs/reiser4/plugin/file/cryptcompress.c
> b/fs/reiser4/plugin/file/cryptcompress.c
> index 2e64374..7d3061d 100644
> --- a/fs/reiser4/plugin/file/cryptcompress.c
> +++ b/fs/reiser4/plugin/file/cryptcompress.c
> @@ -821,7 +821,7 @@ static int need_cut_or_align(struct inode * inode,
> static void align_or_cut_overhead(struct inode * inode,
> struct cluster_handle * ch, rw_op rw)
> {
> - int oh;
> + unsigned int oh;
> cipher_plugin * cplug = inode_cipher_plugin(inode);
>
> assert("edward-1402", need_cipher(inode));
> diff --git a/fs/reiser4/plugin/inode_ops.c b/fs/reiser4/plugin/inode_ops.c
> index 6ac4d13..945a740 100644
> --- a/fs/reiser4/plugin/inode_ops.c
> +++ b/fs/reiser4/plugin/inode_ops.c
> @@ -418,8 +418,7 @@ void *reiser4_follow_link_common(struct dentry
> *dentry, struct nameidata *nd)
> *
> * Uses generic function to check for rwx permissions.
> */
> -int reiser4_permission_common(struct inode *inode, int mask,
> - struct nameidata *nameidata)
> +int reiser4_permission_common(struct inode *inode, int mask)
> {
> return generic_permission(inode, mask, NULL);
> }
> diff --git a/fs/reiser4/plugin/object.h b/fs/reiser4/plugin/object.h
> index 63abb07..88a53a5 100644
> --- a/fs/reiser4/plugin/object.h
> +++ b/fs/reiser4/plugin/object.h
> @@ -25,8 +25,7 @@ int reiser4_mknod_common(struct inode *parent, struct
> dentry *dentry,
here.
> int reiser4_rename_common(struct inode *old_dir, struct dentry *old_name,
> struct inode *new_dir, struct dentry *new_name);
> void *reiser4_follow_link_common(struct dentry *, struct nameidata *data);
> -int reiser4_permission_common(struct inode *, int mask,
> - struct nameidata *nameidata);
> +int reiser4_permission_common(struct inode *, int mask);
And it is space-stuffed.
Documentation/email-clients.txt has some thunderbird help.
> int reiser4_setattr_common(struct dentry *, struct iattr *);
> int reiser4_getattr_common(struct vfsmount *mnt, struct dentry *,
> struct kstat *);
I already fixed up and applied this, didn't I?
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-08-07 19:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-01 13:33 [patch][reiser4] compile warning cleanups Ryan Hope
2008-08-07 18:45 ` Ryan Hope
2008-08-07 19:31 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox