From: Pavel Machek <pavel@suse.cz>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: Huang Ying <ying.huang@intel.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
nigel@nigel.suspend2.net, "Rafael J. Wysocki" <rjw@sisk.pl>,
Andrew Morton <akpm@linux-foundation.org>,
mingo@elte.hu, Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Kexec Mailing List <kexec@lists.infradead.org>
Subject: Re: [PATCH 2/6] kexec jump: check code size in control page
Date: Thu, 7 Aug 2008 22:31:30 +0200 [thread overview]
Message-ID: <20080807203130.GA10331@ucw.cz> (raw)
In-Reply-To: <20080807131557.GB27783@redhat.com>
Hi!
> > PAGE_SIZE/2. This patch adds runtime checking for this.
> >
> > Signed-off-by: Huang Ying <ying.huang@intel.com>
...
> > {
> > if (nx_enabled)
> > set_pages_x(image->control_code_page, 1);
> > +
> > + BUG_ON((unsigned long)kexec_control_page_code_end - \
> > + (unsigned long)relocate_kernel >= PAGE_SIZE/2);
> > +
>
> Run time check is better than nothing but I think in this case it would
> be better if we can catch it at compile time.
>
> One of the methods will be to write a small program of your own and
> put in script/ and at build time check for the size and flag error. May
> be there are other better ways to do this.
BUILD_BUG_ON()?
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2008-08-07 20:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-07 9:05 [PATCH 2/6] kexec jump: check code size in control page Huang Ying
2008-08-07 9:21 ` Pavel Machek
2008-08-07 13:15 ` Vivek Goyal
2008-08-07 20:31 ` Pavel Machek [this message]
2008-08-08 2:44 ` Huang Ying
2008-08-08 13:52 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080807203130.GA10331@ucw.cz \
--to=pavel@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=nigel@nigel.suspend2.net \
--cc=rjw@sisk.pl \
--cc=torvalds@linux-foundation.org \
--cc=vgoyal@redhat.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox