From: Dave Jones <davej@codemonkey.org.uk>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: mark.langsdorf@amd.com, lkml <linux-kernel@vger.kernel.org>,
akpm <akpm@linux-foundation.org>
Subject: Re: [PATCH -next] powernow-k8: fix build errors
Date: Fri, 8 Aug 2008 14:03:47 -0400 [thread overview]
Message-ID: <20080808180347.GQ26295@codemonkey.org.uk> (raw)
In-Reply-To: <20080808105040.291097a2.randy.dunlap@oracle.com>
On Fri, Aug 08, 2008 at 10:50:40AM -0700, Randy Dunlap wrote:
> On Fri, 8 Aug 2008 13:38:22 -0400 Dave Jones wrote:
>
> > I think something like below may be better..
> > Same thing, but with one less ifdef ?
>
> Close, but no cigar.
Yeah, that's what you get for posting before building.
> > diff --git a/arch/x86/kernel/cpu/cpufreq/powernow-k8.c b/arch/x86/kernel/cpu/cpufreq/powernow-k8.c
> > index 7a09ba4..3ba6fd2 100644
> > --- a/arch/x86/kernel/cpu/cpufreq/powernow-k8.c
> > +++ b/arch/x86/kernel/cpu/cpufreq/powernow-k8.c
> > @@ -951,6 +951,7 @@ static void powernow_k8_cpu_exit_acpi(struct powernow_k8_data *data)
> > }
> >
> > #else
> > +static int powernow_k8_cpu_preinit_acpi(struct powernow_k8_data *data) { return -ENODEV; }
> (void) // parameters
I made the same change locally.
> (your) new patch:
I'll punt this on to Linus with your Signed-off-by: and Marks ACKed by.
thanks,
Dave
--
http://www.codemonkey.org.uk
prev parent reply other threads:[~2008-08-08 18:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-08 17:19 [PATCH -next] powernow-k8: fix build errors Randy Dunlap
2008-08-08 17:26 ` Langsdorf, Mark
2008-08-08 17:38 ` Dave Jones
2008-08-08 17:50 ` Randy Dunlap
2008-08-08 18:03 ` Dave Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080808180347.GQ26295@codemonkey.org.uk \
--to=davej@codemonkey.org.uk \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.langsdorf@amd.com \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).