public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Mimi Zohar <zohar@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	Al Viro <viro@ZenIV.linux.org.uk>,
	Stephen Smalley <sds@tycho.nsa.gov>,
	James Morris <jmorris@namei.org>,
	Randy Dunlap <randy.dunlap@oracle.com>,
	safford@watson.ibm.com, serue@linux.vnet.ibm.com,
	sailer@watson.ibm.com, zohar@us.ibm.com
Subject: Re: [PATCH 2/4] integrity: special fs magic
Date: Fri, 8 Aug 2008 12:15:19 -0700	[thread overview]
Message-ID: <20080808191519.GA3704@kroah.com> (raw)
In-Reply-To: <20080808190448.GA3356@kroah.com>

On Fri, Aug 08, 2008 at 12:04:48PM -0700, Greg KH wrote:
> On Fri, Aug 08, 2008 at 02:55:42PM -0400, Mimi Zohar wrote:
> >     - Move special fs magic number definitions to magic.h
> >     - Add magic.h include
> >     
> >     Signed-off-by: Mimi Zohar <zohar@us.ibm.com>
> 
> Why?  What is this patch for?  Are you going to do something with these
> magic values later?

Ok, I now see the follow-up patch that does something with them.

You should say so in this patch.

And is it really ok to be doing things from userspace based on a
filesystem "magic" key?  Those are numbers we have never exported to
userspace before, what happens if they are changed?

thanks,

greg k-h

  reply	other threads:[~2008-08-08 19:17 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20080808184349.999902616@linux.vnet.ibm.com>
2008-08-08 18:55 ` [PATCH 1/4] integrity: TPM internel kernel interface Mimi Zohar
2008-08-09 18:46   ` Christoph Hellwig
2008-08-11 21:13     ` Mimi Zohar
2008-08-12 19:30       ` Christoph Hellwig
2008-08-12 20:57         ` Kenneth Goldman
2008-08-12 21:36           ` Alan Cox
2008-08-13 13:46             ` Kenneth Goldman
2008-08-13 13:40               ` Alan Cox
2008-08-13 14:45                 ` Christoph Hellwig
2008-08-13 16:39                 ` Kenneth Goldman
2008-08-12 23:16           ` Greg KH
2008-08-13 13:58             ` Kenneth Goldman
2008-08-13 16:56             ` Mimi Zohar
2008-08-14 11:12           ` Pavel Machek
2008-08-15 10:37             ` Peter Dolding
2008-08-15 18:50               ` Kenneth Goldman
2008-08-15 19:22                 ` Valdis.Kletnieks
2008-08-15 21:17                 ` Alan Cox
2008-08-18 15:01             ` Kenneth Goldman
2008-08-08 18:55 ` [PATCH 2/4] integrity: special fs magic Mimi Zohar
2008-08-08 19:04   ` Greg KH
2008-08-08 19:15     ` Greg KH [this message]
2008-08-08 19:50       ` Mimi Zohar
2008-08-08 23:07         ` Greg KH
2008-08-09 18:47       ` Christoph Hellwig
2008-08-10 13:48         ` Mimi Zohar
2008-08-08 19:36     ` Mimi Zohar
2008-08-08 23:15   ` Christoph Hellwig
2008-08-08 18:56 ` [PATCH 3/4] integrity: Linux Integrity Module(LIM) Mimi Zohar
2008-08-09 18:53   ` Christoph Hellwig
2008-08-10 13:52     ` Mimi Zohar
2008-08-11 17:02       ` Serge E. Hallyn
2008-08-11 19:08         ` Mimi Zohar
2008-08-11 19:56           ` Serge E. Hallyn
2008-08-12  8:41             ` Peter Dolding
2008-08-12 19:29               ` Christoph Hellwig
2008-08-13 10:44                 ` Peter Dolding
2008-08-13 14:11                   ` David Howells
2008-08-13 22:57                     ` Peter Dolding
2008-08-13 17:03             ` Mimi Zohar
2008-08-12 19:27         ` Christoph Hellwig
2008-08-12 21:19           ` Serge E. Hallyn
2008-08-13 17:03             ` Mimi Zohar
2008-08-12 19:25       ` Christoph Hellwig
2008-08-08 18:56 ` [PATCH 4/4] integrity: IMA as an integrity service provider Mimi Zohar
2008-08-08 20:06   ` Randy Dunlap
2008-10-07 18:00 [PATCH 0/4] integrity Mimi Zohar
2008-10-07 18:00 ` [PATCH 2/4] integrity: special fs magic Mimi Zohar
2008-10-08 13:00   ` Christoph Hellwig
2008-10-08 15:07     ` Mimi Zohar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080808191519.GA3704@kroah.com \
    --to=greg@kroah.com \
    --cc=jmorris@namei.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    --cc=safford@watson.ibm.com \
    --cc=sailer@watson.ibm.com \
    --cc=sds@tycho.nsa.gov \
    --cc=serue@linux.vnet.ibm.com \
    --cc=viro@ZenIV.linux.org.uk \
    --cc=zohar@linux.vnet.ibm.com \
    --cc=zohar@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox