From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: David Miller <davem@davemloft.net>
Cc: a.p.zijlstra@chello.nl, torvalds@linux-foundation.org,
akpm@linux-foundation.org, mingo@elte.hu, tglx@linutronix.de,
marcin.slusarz@gmail.com, linux-kernel@vger.kernel.org,
rostedt@goodmis.org
Subject: Re: [PATCH] printk: robustify printk
Date: Fri, 8 Aug 2008 17:18:21 -0700 [thread overview]
Message-ID: <20080809001820.GS6760@linux.vnet.ibm.com> (raw)
In-Reply-To: <20080808.160254.223161300.davem@davemloft.net>
On Fri, Aug 08, 2008 at 04:02:54PM -0700, David Miller wrote:
> From: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Date: Fri, 08 Aug 2008 20:14:28 +0200
>
> > +struct klogd_wakeup_state {
> > + struct rcu_head head;
> > + int pending;
> > +};
> > +
> > +DEFINE_PER_CPU(struct klogd_wakeup_state, kws);
>
> Since there is not RCU_HEAD_INIT() made on these per-cpu objects, this code
> is depending upon the fact that currently the RCU head is just initialized
> to all zeros.
RCU_HEAD_INIT() is only needed for debugging purposes, when you want
to be sure that any garbage in the rcu_head is due to corruption or
some such. The call_rcu() function always completely initializes the
rcu_head structure.
Thanx, Paul
next prev parent reply other threads:[~2008-08-09 0:18 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-24 12:24 [PATCH 0/2] printk vs rq->lock and xtime lock Peter Zijlstra
2008-03-24 12:24 ` [PATCH 1/2] printk_nowakeup() Peter Zijlstra
2008-03-24 12:24 ` [PATCH 2/2] time: xtime lock vs printk Peter Zijlstra
2008-03-24 14:21 ` Daniel Walker
2008-03-24 14:31 ` [PATCH 0/2] printk vs rq->lock and xtime lock Marcin Slusarz
2008-03-24 17:58 ` Linus Torvalds
2008-03-24 18:15 ` Peter Zijlstra
2008-03-24 18:57 ` Andrew Morton
2008-08-08 13:30 ` Peter Zijlstra
2008-08-08 13:46 ` Peter Zijlstra
2008-08-08 16:41 ` Linus Torvalds
2008-08-08 17:10 ` Peter Zijlstra
2008-08-08 17:25 ` Linus Torvalds
2008-08-08 17:40 ` Peter Zijlstra
2008-08-08 17:48 ` Linus Torvalds
2008-08-08 18:14 ` [PATCH] printk: robustify printk Peter Zijlstra
2008-08-08 18:30 ` Linus Torvalds
2008-08-08 18:33 ` Peter Zijlstra
2008-08-08 19:14 ` Andrew Morton
2008-08-08 19:21 ` Peter Zijlstra
2008-08-08 19:37 ` Andrew Morton
2008-08-08 19:49 ` Peter Zijlstra
2008-08-08 20:32 ` Paul E. McKenney
2008-08-08 20:37 ` Peter Zijlstra
2008-08-08 20:46 ` Andrew Morton
2008-08-08 20:57 ` Linus Torvalds
2008-08-08 21:13 ` Andrew Morton
2008-08-08 20:50 ` Steven Rostedt
2008-08-08 19:47 ` Peter Zijlstra
2008-08-11 10:45 ` Ingo Molnar
2008-08-11 11:03 ` Andi Kleen
2008-08-11 11:22 ` Peter Zijlstra
2008-08-11 11:42 ` Andi Kleen
2008-08-11 14:15 ` Valdis.Kletnieks
2008-08-11 14:29 ` Andi Kleen
2008-08-11 14:55 ` Steven Rostedt
2008-08-11 12:02 ` Ingo Molnar
2008-08-11 12:14 ` Andi Kleen
2008-08-11 11:04 ` Peter Zijlstra
2008-08-11 11:51 ` Ingo Molnar
2008-08-11 12:36 ` Ingo Molnar
2008-08-20 12:40 ` Jiri Kosina
2008-08-20 12:43 ` Peter Zijlstra
2008-08-20 13:40 ` Ingo Molnar
2008-08-11 16:09 ` Paul E. McKenney
2008-08-11 13:22 ` Paul E. McKenney
2008-08-08 20:30 ` Paul E. McKenney
2008-08-08 20:20 ` Paul E. McKenney
2008-08-08 21:35 ` Andi Kleen
2008-08-08 23:02 ` David Miller
2008-08-09 0:18 ` Paul E. McKenney [this message]
2008-08-08 17:52 ` [PATCH 0/2] printk vs rq->lock and xtime lock Steven Rostedt
2008-03-24 18:16 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080809001820.GS6760@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.slusarz@gmail.com \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox