public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <me@felipebalbi.com>
To: Frans Pop <elendil@planet.nl>
Cc: Greg KH <greg@kroah.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [00/03] [RFC] USB debugging rework
Date: Sun, 10 Aug 2008 02:36:01 +0300	[thread overview]
Message-ID: <20080809233600.GC7574@frodo> (raw)
In-Reply-To: <200808100057.58863.elendil@planet.nl>

On Sun, Aug 10, 2008 at 12:57:58AM +0200, Frans Pop wrote:
> Greg KH wrote:
> > I've been annoyed for a long time that we make users go off and rebuild
> > their kernels just to enable usb debug messages.  So finally, here's the
> > start of fixing that issue.
> 
> Will your patches also allow to turn off the usb debugging at some point, 
> for example after system boot has been completed if the debugging was 
> only needed to analyze a boot issue?
> 
> I noticed earlier this week that USB debugging will really flood the 
> syslog and had to rebuild my -rc2 kernel without debugging and reboot to 
> get rid of it. AFAICT with your patches only rebooting would be needed, 
> but it would be even nicer if it also could be turned off (and on?) using 
> a sysfs parameter.

no rebooting. Just rmmod and modprobe again with the parameter set to 0,
although a sysfs file would be nice, or maybe allowing the
/sys/module/*/parameters/* to be writable :-)

I think that should be done in driver core.

-- 
balbi

  reply	other threads:[~2008-08-09 23:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-09  1:38 [00/03] [RFC] USB debugging rework Greg KH
2008-08-09  1:39 ` [01/03] USB: add CONFIG_USB_DEBUG_MESSAGES and usb_dbg() Greg KH
2008-08-09  1:39   ` [02/03] USB: convert the USB core code to use usb_dbg() Greg KH
2008-08-09  1:40     ` [03/03] USB: remove CONFIG_USB_DEBUG Greg KH
2008-08-09 15:04   ` [01/03] USB: add CONFIG_USB_DEBUG_MESSAGES and usb_dbg() Marcin Slusarz
2008-08-10  3:36     ` Greg KH
2008-08-09 22:04 ` [00/03] [RFC] USB debugging rework Pete Zaitcev
2008-08-10  3:35   ` Greg KH
2008-08-09 22:57 ` Frans Pop
2008-08-09 23:36   ` Felipe Balbi [this message]
2008-08-09 23:44     ` Felipe Balbi
2008-08-10  1:38   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080809233600.GC7574@frodo \
    --to=me@felipebalbi.com \
    --cc=elendil@planet.nl \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox