From: Matthew Wilcox <matthew@wil.cx>
To: Grant Grundler <grundler@parisc-linux.org>
Cc: jbarnes@virtuousgeek.org, linux-kernel@vger.kernel.org,
eric@anholt.net, Matthew Wilcox <willy@linux.intel.com>
Subject: Re: [PATCH 3/3] PCI: Add pci_read_base() API
Date: Sat, 9 Aug 2008 19:01:54 -0600 [thread overview]
Message-ID: <20080810010153.GM8618@parisc-linux.org> (raw)
In-Reply-To: <20080810004750.GA2617@colo.lackof.org>
On Sat, Aug 09, 2008 at 06:47:50PM -0600, Grant Grundler wrote:
> This would be a suitable comment in the code.
> My point still stands: The next person modifying the code will
> need to know how/what to test and where to look it up.
It turns out Eric doesn't need this code after all. So we have no
users, and this patch (3/3) isn't going into the tree. 1/3 and 2/3
are already in, and make the code easier to follow while adding no
additional functionality.
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
prev parent reply other threads:[~2008-08-10 1:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-28 17:38 pci_read_base patch series Matthew Wilcox
2008-07-28 17:38 ` [PATCH 1/3] Rewrite PCI BAR reading code Matthew Wilcox
2008-07-28 17:39 ` [PATCH 2/3] PCI: Handle 64-bit resources better on 32-bit machines Matthew Wilcox
2008-07-28 21:30 ` Jesse Barnes
2008-07-29 0:46 ` Matthew Wilcox
2008-07-28 17:39 ` [PATCH 3/3] PCI: Add pci_read_base() API Matthew Wilcox
2008-07-29 1:22 ` Zhao, Yu
2008-07-29 1:49 ` Matthew Wilcox
2008-07-29 2:36 ` Zhao, Yu
2008-08-04 6:38 ` Grant Grundler
2008-08-06 14:38 ` Matthew Wilcox
2008-08-10 0:47 ` Grant Grundler
2008-08-10 1:01 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080810010153.GM8618@parisc-linux.org \
--to=matthew@wil.cx \
--cc=eric@anholt.net \
--cc=grundler@parisc-linux.org \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox