From: Christoph Lameter <cl@linux-foundation.org>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: akpm@linux-foundation.org, Christoph Lameter <clameter@sgi.com>,
Christoph Lameter <cl@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org
Cc: Mel Gorman <mel@skynet.ie>
Cc: andi@firstfloor.org
Cc: Rik van Riel <riel@redhat.com>
Cc: mpm@selenic.com
Cc: Dave Chinner <david@fromorbit.com>
Subject: [patch 01/19] slub: Add defrag_ratio field and sysfs support.
Date: Mon, 11 Aug 2008 08:06:17 -0700 [thread overview]
Message-ID: <20080811150653.575096604@quilx.com> (raw)
In-Reply-To: 20080811150616.207532384@quilx.com
[-- Attachment #1: 0001-SLUB-Add-defrag_ratio-field-and-sysfs-support.patch --]
[-- Type: text/plain, Size: 2709 bytes --]
The defrag_ratio is used to set the threshold at which defragmentation
should be attempted on a slab page.
The allocation ratio is measured by the percentage of the available slots
allocated.
Add a defrag ratio field and set it to 30% by default. A limit of 30% specified
that less than 3 out of 10 available slots for objects are in use before
slab defragmeentation runs.
Reviewed-by: Rik van Riel <riel@redhat.com>
Signed-off-by: Christoph Lameter <clameter@sgi.com>
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Christoph Lameter <cl@linux-foundation.org>
---
include/linux/slub_def.h | 7 +++++++
mm/slub.c | 23 +++++++++++++++++++++++
2 files changed, 30 insertions(+)
Index: linux-next/include/linux/slub_def.h
===================================================================
--- linux-next.orig/include/linux/slub_def.h 2008-08-11 07:42:32.301017715 -0700
+++ linux-next/include/linux/slub_def.h 2008-08-11 07:50:11.382348462 -0700
@@ -89,6 +89,13 @@ struct kmem_cache {
void (*ctor)(void *);
int inuse; /* Offset to metadata */
int align; /* Alignment */
+ int defrag_ratio; /*
+ * Ratio used to check the percentage of
+ * objects allocate in a slab page.
+ * If less than this ratio is allocated
+ * then reclaim attempts are made.
+ */
+
const char *name; /* Name (only for display!) */
struct list_head list; /* List of slab caches */
#ifdef CONFIG_SLUB_DEBUG
Index: linux-next/mm/slub.c
===================================================================
--- linux-next.orig/mm/slub.c 2008-08-11 07:42:34.392348172 -0700
+++ linux-next/mm/slub.c 2008-08-11 07:50:11.802347432 -0700
@@ -2324,6 +2324,7 @@ static int kmem_cache_open(struct kmem_c
goto error;
s->refcount = 1;
+ s->defrag_ratio = 30;
#ifdef CONFIG_NUMA
s->remote_node_defrag_ratio = 100;
#endif
@@ -4056,6 +4057,27 @@ static ssize_t free_calls_show(struct km
}
SLAB_ATTR_RO(free_calls);
+static ssize_t defrag_ratio_show(struct kmem_cache *s, char *buf)
+{
+ return sprintf(buf, "%d\n", s->defrag_ratio);
+}
+
+static ssize_t defrag_ratio_store(struct kmem_cache *s,
+ const char *buf, size_t length)
+{
+ unsigned long ratio;
+ int err;
+
+ err = strict_strtoul(buf, 10, &ratio);
+ if (err)
+ return err;
+
+ if (ratio < 100)
+ s->defrag_ratio = ratio;
+ return length;
+}
+SLAB_ATTR(defrag_ratio);
+
#ifdef CONFIG_NUMA
static ssize_t remote_node_defrag_ratio_show(struct kmem_cache *s, char *buf)
{
@@ -4163,6 +4185,7 @@ static struct attribute *slab_attrs[] =
&shrink_attr.attr,
&alloc_calls_attr.attr,
&free_calls_attr.attr,
+ &defrag_ratio_attr.attr,
#ifdef CONFIG_ZONE_DMA
&cache_dma_attr.attr,
#endif
--
next prev parent reply other threads:[~2008-08-11 15:16 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-11 15:06 [patch 00/19] Slab Fragmentation Reduction V14 Christoph Lameter
2008-08-11 15:06 ` Christoph Lameter [this message]
2008-08-13 0:40 ` [patch 01/19] slub: Add defrag_ratio field and sysfs support Greg KH
2008-08-11 15:06 ` [patch 02/19] slub: Replace ctor field with ops field in /sys/slab/* Christoph Lameter
2008-08-11 15:06 ` [patch 03/19] slub: Add get() and kick() methods Christoph Lameter
2008-08-11 15:06 ` [patch 04/19] slub: Sort slab cache list and establish maximum objects for defrag slabs Christoph Lameter
2008-08-11 15:06 ` [patch 05/19] slub: Slab defrag core Christoph Lameter
2008-08-11 15:06 ` [patch 06/19] slub: Add KICKABLE to avoid repeated kick() attempts Christoph Lameter
2008-08-11 15:06 ` [patch 07/19] slub: Extend slabinfo to support -D and -F options Christoph Lameter
2008-08-11 15:06 ` [patch 08/19] slub/slabinfo: add defrag statistics Christoph Lameter
2008-08-11 15:06 ` [patch 09/19] slub: Trigger defragmentation from memory reclaim Christoph Lameter
2008-08-11 15:06 ` [patch 10/19] buffer heads: Support slab defrag Christoph Lameter
2008-08-11 15:06 ` [patch 11/19] inodes: Support generic defragmentation Christoph Lameter
2008-08-11 15:06 ` [patch 12/19] Filesystem: Ext2 filesystem defrag Christoph Lameter
2008-08-11 15:06 ` [patch 13/19] Filesystem: Ext3 " Christoph Lameter
2008-08-11 15:06 ` [patch 14/19] Filesystem: Ext4 " Christoph Lameter
2008-08-11 15:06 ` [patch 15/19] Filesystem: XFS slab defragmentation Christoph Lameter
2008-08-12 0:20 ` Dave Chinner
2008-08-12 7:08 ` Pekka Enberg
2008-08-12 18:21 ` Christoph Lameter
2008-08-13 6:38 ` Pekka Enberg
2008-08-11 15:06 ` [patch 16/19] Filesystem: /proc filesystem support for slab defrag Christoph Lameter
2008-08-11 15:06 ` [patch 17/19] Filesystem: Slab defrag: Reiserfs support Christoph Lameter
2008-08-11 15:06 ` [patch 18/19] dentries: Add constructor Christoph Lameter
2008-08-13 7:12 ` Pekka Enberg
2008-08-11 15:06 ` [patch 19/19] dentries: dentry defragmentation Christoph Lameter
2008-08-12 6:50 ` [patch 00/19] Slab Fragmentation Reduction V14 Pekka Enberg
-- strict thread matches above, loose matches on Subject: below --
2008-05-10 2:21 [patch 00/19] Slab Fragmentation Reduction V13 Christoph Lameter
2008-05-10 2:21 ` [patch 01/19] slub: Add defrag_ratio field and sysfs support Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080811150653.575096604@quilx.com \
--to=cl@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox