public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] pci-calgary: fix function declaration
@ 2008-08-07 22:14 Randy Dunlap
  2008-08-08  7:00 ` Muli Ben-Yehuda
  0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2008-08-07 22:14 UTC (permalink / raw)
  To: lkml; +Cc: x86, akpm, muli, jdmason

From: Randy Dunlap <randy.dunlap@oracle.com>
cc: muli@il.ibm.com, jdmason@kudzu.us

Fix function declaration:

linux-next-20080807/arch/x86/kernel/pci-calgary_64.c:1353:36: warning: non-ANSI function declaration of function 'get_tce_space_from_tar'

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 arch/x86/kernel/pci-calgary_64.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20080807.orig/arch/x86/kernel/pci-calgary_64.c
+++ linux-next-20080807/arch/x86/kernel/pci-calgary_64.c
@@ -1350,7 +1350,7 @@ static void calgary_init_bitmap_from_tce
  * Function for kdump case. Get the tce tables from first kernel
  * by reading the contents of the base adress register of calgary iommu
  */
-static void get_tce_space_from_tar()
+static void get_tce_space_from_tar(void)
 {
 	int bus;
 	void __iomem *target;


---
~Randy
Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
http://linuxplumbersconf.org/

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] pci-calgary: fix function declaration
  2008-08-07 22:14 [PATCH] pci-calgary: fix function declaration Randy Dunlap
@ 2008-08-08  7:00 ` Muli Ben-Yehuda
  2008-08-11 16:48   ` Ingo Molnar
  0 siblings, 1 reply; 3+ messages in thread
From: Muli Ben-Yehuda @ 2008-08-08  7:00 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: lkml, x86, akpm, jdmason

On Thu, Aug 07, 2008 at 03:14:55PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
> cc: muli@il.ibm.com, jdmason@kudzu.us
> 
> Fix function declaration:
> 
> linux-next-20080807/arch/x86/kernel/pci-calgary_64.c:1353:36: warning: non-ANSI function declaration of function 'get_tce_space_from_tar'
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>

Acked-by: Muli Ben-Yehuda <muli@il.ibm.com>

Cheers,
Muli
-- 
Workshop on I/O Virtualization (WIOV '08)
Co-located with OSDI '08, Dec 2008, San Diego, CA
http://www.usenix.org/wiov08

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] pci-calgary: fix function declaration
  2008-08-08  7:00 ` Muli Ben-Yehuda
@ 2008-08-11 16:48   ` Ingo Molnar
  0 siblings, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2008-08-11 16:48 UTC (permalink / raw)
  To: Muli Ben-Yehuda; +Cc: Randy Dunlap, lkml, x86, akpm, jdmason


* Muli Ben-Yehuda <muli@il.ibm.com> wrote:

> On Thu, Aug 07, 2008 at 03:14:55PM -0700, Randy Dunlap wrote:
> > From: Randy Dunlap <randy.dunlap@oracle.com>
> > cc: muli@il.ibm.com, jdmason@kudzu.us
> > 
> > Fix function declaration:
> > 
> > linux-next-20080807/arch/x86/kernel/pci-calgary_64.c:1353:36: warning: non-ANSI function declaration of function 'get_tce_space_from_tar'
> > 
> > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Acked-by: Muli Ben-Yehuda <muli@il.ibm.com>

applied to tip/x86/urgent - thanks.

	Ingo

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-08-11 16:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-07 22:14 [PATCH] pci-calgary: fix function declaration Randy Dunlap
2008-08-08  7:00 ` Muli Ben-Yehuda
2008-08-11 16:48   ` Ingo Molnar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox