public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Max Krasnyansky <maxk@qualcomm.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	lizf@cn.fujitsu.com, jeff.chua.linux@gmail.com,
	Glauber Costa <gcosta@redhat.com>
Subject: Re: [PATCH] Resurect proper handling of maxcpus= kernel option
Date: Mon, 11 Aug 2008 20:38:14 +0200	[thread overview]
Message-ID: <20080811183814.GA12788@elte.hu> (raw)
In-Reply-To: <48A084C8.6050204@qualcomm.com>


* Max Krasnyansky <maxk@qualcomm.com> wrote:

> > This will need some test time on 32-bit as that is where this 
> > represents a material change. ( albeit what matters most is the 
> > maxcpus=1 distinction - and for that nosmp can be used as well to 
> > turn off multi-cpu support altogether. So we could do this in 
> > v2.6.27 as well. )
> 
> So far we got a couple of reports that it works as expected on 32 
> (both laptop and server/desktop).

Yes, but the usecase i'm worried about is when say maxcpus=1 was used to 
_prevent_ an SMP bootup - because the system would not work otherwise.

i guess we want to tickle those systems anyway as that case is not 
supposed to happen (and it can always be totally disabled via nosmp or 
noapic).

So i'm not against your fix/change per se, i just wanted to highlight 
that it has some impact on existing uses of maxcpus that is outside of 
your cpu-hotplug usecase.

	Ingo

  reply	other threads:[~2008-08-11 18:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-06 20:00 [PATCH] Resurect proper handling of maxcpus= kernel option Max.Krasnyansky
2008-08-06 20:23 ` Max Krasnyansky
2008-08-07  4:00 ` Li Zefan
2008-08-07  5:48   ` Jeff Chua
2008-08-07 17:22     ` Max Krasnyansky
2008-08-07 17:21   ` Max Krasnyansky
2008-08-08  2:13     ` Li Zefan
2008-08-11 18:16 ` Ingo Molnar
2008-08-11 18:28   ` Max Krasnyansky
2008-08-11 18:38     ` Ingo Molnar [this message]
2008-08-11 18:46       ` Max Krasnyansky
2008-08-11 18:40   ` Max Krasnyansky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080811183814.GA12788@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=gcosta@redhat.com \
    --cc=jeff.chua.linux@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizf@cn.fujitsu.com \
    --cc=maxk@qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox