From: Ingo Molnar <mingo@elte.hu>
To: Andreas Herrmann <andreas.herrmann3@amd.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH 0/2] x86: fix memory leaks when doing CPU hotplug
Date: Mon, 11 Aug 2008 21:40:15 +0200 [thread overview]
Message-ID: <20080811194013.GI12788@elte.hu> (raw)
In-Reply-To: <20080806082400.GC5427@alberich.amd.com>
* Andreas Herrmann <andreas.herrmann3@amd.com> wrote:
> Following patches fix two memory leaks with CPU hotplug. Some per CPU
> data is allocated each time a CPU is set online. But this space is
> never freed.
>
> Usually this memory leak is not a big deal (for normal CPU hotplug
> usage). But during stress tests with lots of CPU offline/online cycles
> this really matters.
>
> The entire leak is 40K (10 pages) for each offline/online cycle per
> CPU. I've verified both fixes performing more than 90000 CPU
> offline/online cycles.
applied to tip/x86/core, thanks Andreas.
> This is not a regression but I think it's still 2.6.27 material.
> Please apply.
it's tricky code so i guess it's best to let it cook in tip/master a
bit. If it does not show up upstream by say -rc4 time could you please
ping us about it?
Ingo
next prev parent reply other threads:[~2008-08-11 19:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-06 8:24 [PATCH 0/2] x86: fix memory leaks when doing CPU hotplug Andreas Herrmann
2008-08-06 8:27 ` [PATCH 1/2] x86: pda_init(): fix memory leak when using " Andreas Herrmann
2008-08-06 8:29 ` [PATCH 2/2] x86: cpu_init(): " Andreas Herrmann
2008-08-11 19:40 ` Ingo Molnar [this message]
2008-09-02 7:14 ` [PATCH 0/2] x86: fix memory leaks when doing " Andreas Herrmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080811194013.GI12788@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=andreas.herrmann3@amd.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox