Re: Kernel oops with 2.6.26, padlock and ipsec: probably problem with fpu state changes

Herbert Xu
2008-08-09T01:49:49Z

On Fri, Aug 08, 2008 at 12:01:15PM -0700, H. Peter Anvin wrote:
>
> It's technically overkill, if (and only if!) these instructions don't
> actually touch the SSE state (most likely they're using the SSE
> pipeline, and need this stuff to deal with power management issues.)

Yes the PadLock uses the SSE pipeline, but doesn't touch any
of the state.

> However, overkill is a good way to make sure something is dead.
> Applying the patch will make sure we fix the regression, and we can
> worry about optimizing this further post-2.6.27.

Do we really need the FPU changes right now? I'd prefer for that
to be backed out until a proper solution is found. Disabling
preemption around crypto is really bad for scheduling latency.

Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt