Re: Kernel oops with 2.6.26, padlock and ipsec: probably problem with fpu state changes

Herbert Xu
2008-08-09T01:24:28Z

On Sat, Aug 09, 2008 at 08:38:30AM +0800, Herbert Xu wrote:
>
> If there is a significant degradation I suggest that we back out
> the FPU changes. Making your competitor's processor go slow is
> not a nice thing to do, especially when you've just released a
> processor in the same space.
>
> If the degradation is small then I'll push it to Linus.

Actually the patch is totally unacceptable as it is. Disabling
preemption around padlock crypto operations is going to make the
latency for RT go through the roof. Please find a solution that
doesn't involve that or just back out the FPU changes.

Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt